Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CHOOSER_UNBUNDLED -> droidfood

Browse Source 
Has been in teamfood since Oct 28. A couple of minor ("normal") bugs
found during teamfood, but no systematic issues around unbundling.

Modify unit test to accept ReleasedFlag as well.

Bug: 254512507
Test: Build
Change-Id: I8db59d16715cfce5e9cf86fcbb1fbb28d125152e
This commit is contained in:
Matt Casey
2023-01-30 16:12:56 +00:00
parent 7183782a78
commit d2afe4bf2d
2 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/SystemUI/src/com/android/systemui/flags/Flags.kt
View File

@@ -529,7 +529,7 @@ object Flags {
// 1500 - chooser aka sharesheet
// TODO(b/254512507): Tracking Bug
val CHOOSER_UNBUNDLED = unreleasedFlag(1500, "chooser_unbundled", teamfood = true)
val CHOOSER_UNBUNDLED = releasedFlag(1500, "chooser_unbundled")
// TODO(b/266983432) Tracking Bug
val SHARESHEET_CUSTOM_ACTIONS = unreleasedFlag(1501, "sharesheet_custom_actions")

21
packages/SystemUI/tests/src/com/android/systemui/ChooserSelectorTest.kt
View File

@@ -11,6 +11,7 @@ import com.android.systemui.flags.FeatureFlags
import com.android.systemui.flags.Flag
import com.android.systemui.flags.FlagListenable
import com.android.systemui.flags.Flags
import com.android.systemui.flags.ReleasedFlag
import com.android.systemui.flags.UnreleasedFlag
import com.android.systemui.settings.UserTracker
import com.android.systemui.util.mockito.any
@@ -102,7 +103,7 @@ class ChooserSelectorTest : SysuiTestCase() {
@Test
fun initialize_enablesUnbundledChooser_whenFlagEnabled() {
// Arrange
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(true)
setFlagMock(true)
// Act
chooserSelector.start()
@@ -118,7 +119,7 @@ class ChooserSelectorTest : SysuiTestCase() {
@Test
fun initialize_disablesUnbundledChooser_whenFlagDisabled() {
// Arrange
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(false)
setFlagMock(false)
// Act
chooserSelector.start()
@@ -134,7 +135,7 @@ class ChooserSelectorTest : SysuiTestCase() {
@Test
fun enablesUnbundledChooser_whenFlagBecomesEnabled() {
// Arrange
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(false)
setFlagMock(false)
chooserSelector.start()
verify(mockFeatureFlags).addListener(
eq<Flag<*>>(Flags.CHOOSER_UNBUNDLED),
@@ -147,7 +148,7 @@ class ChooserSelectorTest : SysuiTestCase() {
)
// Act
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(true)
setFlagMock(true)
flagListener.value.onFlagChanged(TestFlagEvent(Flags.CHOOSER_UNBUNDLED.name))
// Assert
@@ -161,7 +162,7 @@ class ChooserSelectorTest : SysuiTestCase() {
@Test
fun disablesUnbundledChooser_whenFlagBecomesDisabled() {
// Arrange
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(true)
setFlagMock(true)
chooserSelector.start()
verify(mockFeatureFlags).addListener(
eq<Flag<*>>(Flags.CHOOSER_UNBUNDLED),
@@ -174,7 +175,7 @@ class ChooserSelectorTest : SysuiTestCase() {
)
// Act
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(false)
setFlagMock(false)
flagListener.value.onFlagChanged(TestFlagEvent(Flags.CHOOSER_UNBUNDLED.name))
// Assert
@@ -188,7 +189,7 @@ class ChooserSelectorTest : SysuiTestCase() {
@Test
fun doesNothing_whenAnotherFlagChanges() {
// Arrange
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(false)
setFlagMock(false)
chooserSelector.start()
verify(mockFeatureFlags).addListener(
eq<Flag<*>>(Flags.CHOOSER_UNBUNDLED),
@@ -197,13 +198,17 @@ class ChooserSelectorTest : SysuiTestCase() {
clearInvocations(mockPackageManager)
// Act
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(false)
flagListener.value.onFlagChanged(TestFlagEvent("other flag"))
// Assert
verifyZeroInteractions(mockPackageManager)
}
private fun setFlagMock(enabled: Boolean) {
whenever(mockFeatureFlags.isEnabled(any<UnreleasedFlag>())).thenReturn(enabled)
whenever(mockFeatureFlags.isEnabled(any<ReleasedFlag>())).thenReturn(enabled)
}
private class TestFlagEvent(override val flagName: String) : FlagListenable.FlagEvent {
override fun requestNoRestart() {}
}