Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Camera: Move the device state listener to CameraManagerGlobal

Browse Source 
Only one device state listener instance is typically needed
per camera client process.

Bug: 272246314
Test: Camera CTS
Change-Id: I8ee345ec1de7e803436296dfec45184c5387248d
This commit is contained in:
Emilian Peev
2023-03-08 16:40:07 -08:00
parent 744623808f
commit d207e0566e
1 changed files with 18 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
core/java/android/hardware/camera2/CameraManager.java
View File

@@ -152,21 +152,8 @@ public final class CameraManager {
mContext.checkSelfPermission(CAMERA_OPEN_CLOSE_LISTENER_PERMISSION) ==
PackageManager.PERMISSION_GRANTED;
}
mFoldStateListener = new FoldStateListener(context);
try {
context.getSystemService(DeviceStateManager.class).registerCallback(
new HandlerExecutor(CameraManagerGlobal.get().getDeviceStateHandler()),
mFoldStateListener);
} catch (IllegalStateException e) {
Log.v(TAG, "Failed to register device state listener!");
Log.v(TAG, "Device state dependent characteristics updates will not be functional!");
mFoldStateListener = null;
}
}
private FoldStateListener mFoldStateListener;
/**
* @hide
*/
@@ -228,12 +215,7 @@ public final class CameraManager {
* @hide
*/
public void registerDeviceStateListener(@NonNull CameraCharacteristics chars) {
synchronized (mLock) {
DeviceStateListener listener = chars.getDeviceStateListener();
if (mFoldStateListener != null) {
mFoldStateListener.addDeviceStateListener(listener);
}
}
CameraManagerGlobal.get().registerDeviceStateListener(chars, mContext);
}
/**
@@ -1781,6 +1763,7 @@ public final class CameraManager {
private HandlerThread mDeviceStateHandlerThread;
private Handler mDeviceStateHandler;
private FoldStateListener mFoldStateListener;
// Singleton, don't allow construction
private CameraManagerGlobal() { }
@@ -1795,7 +1778,8 @@ public final class CameraManager {
return gCameraManager;
}
public Handler getDeviceStateHandler() {
public void registerDeviceStateListener(@NonNull CameraCharacteristics chars,
@NonNull Context ctx) {
synchronized(mLock) {
if (mDeviceStateHandlerThread == null) {
mDeviceStateHandlerThread = new HandlerThread(TAG);
@@ -1803,7 +1787,20 @@ public final class CameraManager {
mDeviceStateHandler = new Handler(mDeviceStateHandlerThread.getLooper());
}
return mDeviceStateHandler;
if (mFoldStateListener == null) {
mFoldStateListener = new FoldStateListener(ctx);
try {
ctx.getSystemService(DeviceStateManager.class).registerCallback(
new HandlerExecutor(mDeviceStateHandler), mFoldStateListener);
} catch (IllegalStateException e) {
Log.v(TAG, "Failed to register device state listener!");
Log.v(TAG, "Device state dependent characteristics updates will not be" +
"functional!");
return;
}
}
mFoldStateListener.addDeviceStateListener(chars.getDeviceStateListener());
}
}