Fix SIM PIN listener registration

User correct lifecycle methods for listener regristion,
otherwise error messages would show up on the shared text field

Test: add/remove locked sim card
Test: solve sim challenge, go to bouncer
Fixes: 130906933
Change-Id: I5327c447b770da1148c3e3ef19c6a75e69832a90
This commit is contained in:
Lucas Dupin
2019-04-19 15:03:51 -07:00
parent 0a71ae9536
commit d1d60c3ac3

View File

@@ -135,7 +135,6 @@ public class KeyguardSimPinView extends KeyguardPinBasedInputView {
return;
}
// Sending empty PIN here to query the number of remaining PIN attempts
new CheckSimPin("", mSubId) {
void onSimCheckResponse(final int result, final int attemptsRemaining) {
@@ -216,22 +215,17 @@ public class KeyguardSimPinView extends KeyguardPinBasedInputView {
}
@Override
protected void onAttachedToWindow() {
super.onAttachedToWindow();
public void showUsabilityHint() {
}
@Override
public void onResume(int reason) {
super.onResume(reason);
KeyguardUpdateMonitor.getInstance(mContext).registerCallback(mUpdateMonitorCallback);
resetState();
}
@Override
protected void onDetachedFromWindow() {
super.onDetachedFromWindow();
KeyguardUpdateMonitor.getInstance(mContext).removeCallback(mUpdateMonitorCallback);
}
@Override
public void showUsabilityHint() {
}
@Override
public void onPause() {
// dismiss the dialog.
@@ -239,6 +233,7 @@ public class KeyguardSimPinView extends KeyguardPinBasedInputView {
mSimUnlockProgressDialog.dismiss();
mSimUnlockProgressDialog = null;
}
KeyguardUpdateMonitor.getInstance(mContext).removeCallback(mUpdateMonitorCallback);
}
/**