Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix isSetWallpaperAllowed secondary user

Browse Source 
isSetWallpaperAllowed calls hasUserRestriction
which has a permission check that was violated
because isSetWallpaperAllowed was calling from
the wrong user (the system rather than the
original caller).

Bug: 143958690
Test: Go to seconary user and try to change wallpaper
Change-Id: I42f8ed17fb76cb6f84d0c11266f163356656c0ac
This commit is contained in:
Bookatz
2019-11-05 17:25:53 -08:00
parent bbf394bf19
commit cfc5d19eb6
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
services/core/java/com/android/server/wallpaper/WallpaperManagerService.java
View File

@@ -77,6 +77,7 @@ import android.os.SELinux;
import android.os.SystemClock;
import android.os.UserHandle;
import android.os.UserManager;
import android.os.UserManagerInternal;
import android.os.storage.StorageManager;
import android.service.wallpaper.IWallpaperConnection;
import android.service.wallpaper.IWallpaperEngine;
@@ -2747,12 +2748,19 @@ public class WallpaperManagerService extends IWallpaperManager.Stub
return false; // callingPackage was faked.
}
// TODO(b/144048540): DPM needs to take into account the userId, not just the package.
final DevicePolicyManager dpm = mContext.getSystemService(DevicePolicyManager.class);
if (dpm.isDeviceOwnerApp(callingPackage) || dpm.isProfileOwnerApp(callingPackage)) {
return true;
}
final UserManager um = (UserManager) mContext.getSystemService(Context.USER_SERVICE);
return !um.hasUserRestriction(UserManager.DISALLOW_SET_WALLPAPER);
final int callingUserId = UserHandle.getCallingUserId();
final long ident = Binder.clearCallingIdentity();
try {
UserManagerInternal umi = LocalServices.getService(UserManagerInternal.class);
return !umi.hasUserRestriction(UserManager.DISALLOW_SET_WALLPAPER, callingUserId);
} finally {
Binder.restoreCallingIdentity(ident);
}
}
@Override