Revert "Avoid calling updateSurface twice when dimming is applied."

This reverts commit 9c4b4e14a0.

Reason for revert: Causes increased memory as reported in b/231834913

Change-Id: I95884e6f8b8416a6b8c85637dab5540f09eb89e1

core/java/android/service/wallpaper/WallpaperService.java

@@ -904,6 +904,7 @@ public abstract class WallpaperService extends Service {
             // based on its default wallpaper color hints.
             mShouldDim = dimAmount != 0f || mShouldDimByDefault;
             updateSurfaceDimming();
+            updateSurface(false, false, true);
         }
 
         private void updateSurfaceDimming() {
@@ -940,7 +941,6 @@ public abstract class WallpaperService extends Service {
             } else {
                 Log.v(TAG, "Setting wallpaper dimming: " + 0);
                 surfaceControlTransaction.setAlpha(mBbqSurfaceControl, 1.0f).apply();
-                updateSurface(false, false, true);
             }
 
             mPreviousWallpaperDimAmount = mWallpaperDimAmount;