Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add debugging to diagnose failure

Browse Source 
Bug: 186558987
Test: Manual. Builds and runs
Change-Id: Ia65d60590f33f4321697e9e1814b47f5e185bf99
This commit is contained in:
Todd Kennedy
2021-05-03 14:54:18 -07:00
parent f3c059b9f0
commit ce717adc8d
1 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
services/core/java/com/android/server/pm/PackageManagerService.java
View File

@@ -26019,18 +26019,29 @@ public class PackageManagerService extends IPackageManager.Stub
@Override
public String[] getNamesForUids(int[] uids) throws RemoteException {
if (uids == null || uids.length == 0) {
return null;
}
final String[] names = PackageManagerService.this.getNamesForUids(uids);
final String[] results = (names != null) ? names : new String[uids.length];
// massage results so they can be parsed by the native binder
for (int i = results.length - 1; i >= 0; --i) {
if (results[i] == null) {
results[i] = "";
String[] names = null;
String[] results = null;
try {
if (uids == null || uids.length == 0) {
return null;
}
names = PackageManagerService.this.getNamesForUids(uids);
results = (names != null) ? names : new String[uids.length];
// massage results so they can be parsed by the native binder
for (int i = results.length - 1; i >= 0; --i) {
if (results[i] == null) {
results[i] = "";
}
}
return results;
} catch (Throwable t) {
// STOPSHIP(186558987): revert addition of try/catch/log
Slog.e(TAG, "uids: " + Arrays.toString(uids));
Slog.e(TAG, "names: " + Arrays.toString(names));
Slog.e(TAG, "results: " + Arrays.toString(results));
Slog.e(TAG, "throwing exception", t);
throw t;
}
return results;
}
// NB: this differentiates between preloads and sideloads