Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix screenshot preview accessibility label

Browse Source 
Changes label to match the "Edit" button. Also makes the description
more correct when the preview is /not/ tappable (i.e. when the
screenshot was taken, but we haven't successfully saved it to disk
yet).

Test: manual
Fixes: 152834239
Change-Id: Iae406bcc672e56445e620349851e94cfaf97859a
This commit is contained in:
Miranda Kephart
2020-04-01 10:05:22 -04:00
parent f4d9f16f1a
commit caf82becec
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/SystemUI/res/values/strings.xml
View File

@@ -235,8 +235,8 @@
your organization</string>
<!-- Content description indicating that tapping a button will dismiss the screenshots UI [CHAR LIMIT=NONE] -->
<string name="screenshot_dismiss_ui_description">Dismiss screenshot</string>
<!-- Content description indicating that tapping will open an app to view/edit the screenshot. [CHAR LIMIT=NONE] -->
<string name="screenshot_preview_description">Open screenshot</string>
<!-- Content description indicating that the view is a preview of the screenshot that was just taken [CHAR LIMIT=NONE] -->
<string name="screenshot_preview_description">Screenshot preview</string>
<!-- Notification title displayed for screen recording [CHAR LIMIT=50]-->
<string name="screenrecord_name">Screen Recorder</string>

3
packages/SystemUI/src/com/android/systemui/screenshot/GlobalScreenshot.java
View File

@@ -422,6 +422,8 @@ public class GlobalScreenshot implements ViewTreeObserver.OnComputeInternalInset
mDismissButton.setVisibility(View.GONE);
mScreenshotView.setVisibility(View.GONE);
mScreenshotView.setLayerType(View.LAYER_TYPE_NONE, null);
mScreenshotView.setContentDescription(
mContext.getResources().getString(R.string.screenshot_preview_description));
}
/**
@@ -606,6 +608,7 @@ public class GlobalScreenshot implements ViewTreeObserver.OnComputeInternalInset
Log.e(TAG, "Intent cancelled", e);
}
});
mScreenshotView.setContentDescription(action.title);
}
mActionsView.addView(actionChip);
}