Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Set insert mode color to be 20% of the text color

Browse Source 
Previously the insert mode color was based on the theme's primary color,
which could be invisible against the background for some themes.

Bug: 278205678
Test: atest TextViewHandwritingGestureTest
Change-Id: Ia7d212b73c0ca498bef26f8202857a9c63712b85
This commit is contained in:
Justin Ghan
2023-06-02 13:40:14 -07:00
parent f4a8db8305
commit cabb5e1c16
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/java/android/widget/Editor.java
View File

@@ -8112,16 +8112,10 @@ public class Editor {
mHighlightPaint = new Paint();
mHighlightPath = new Path();
// The highlight color is supposed to be 12% of the color primary40. We can't
// directly access Material 3 theme. But because Material 3 sets the colorPrimary to
// be primary40, here we hardcoded it to be 12% of colorPrimary.
final TypedValue typedValue = new TypedValue();
mTextView.getContext().getTheme()
.resolveAttribute(R.attr.colorPrimary, typedValue, true);
final int colorPrimary = typedValue.data;
final int highlightColor = ColorUtils.setAlphaComponent(colorPrimary,
(int) (0.12f * Color.alpha(colorPrimary)));
mHighlightPaint.setColor(highlightColor);
// Insert mode highlight color is 20% opacity of the default text color.
int color = mTextView.getTextColors().getDefaultColor();
color = ColorUtils.setAlphaComponent(color, (int) (0.2f * Color.alpha(color)));
mHighlightPaint.setColor(color);
}
/**