Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix duplicate dagger binding of MediaProjectionAppSelectorActivity

Browse Source 
It was bound twice:
1 - Constructor injection
2 - Subcomponent `@BindsInstance`

Fixes: 292682275
Test: Build & Run
Change-Id: I8676153b99a32bd06b3978444f4cde4b04193d90
This commit is contained in:
Chris Göllner
2023-07-25 19:18:45 +01:00
parent 9958309dac
commit c9e16e6333
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/SystemUI/src/com/android/systemui/media/MediaProjectionAppSelectorActivity.kt
View File

@@ -85,7 +85,7 @@ class MediaProjectionAppSelectorActivity(
public override fun onCreate(bundle: Bundle?) {
lifecycleRegistry.handleLifecycleEvent(Lifecycle.Event.ON_CREATE)
component = componentFactory.create(activity = this, view = this, resultHandler = this)
component = componentFactory.create(view = this, resultHandler = this)
component.lifecycleObservers.forEach { lifecycle.addObserver(it) }
// Create a separate configuration controller for this activity as the configuration

1
packages/SystemUI/src/com/android/systemui/mediaprojection/appselector/MediaProjectionAppSelectorComponent.kt
View File

@@ -161,7 +161,6 @@ interface MediaProjectionAppSelectorComponent {
interface Factory {
/** Create a factory to inject the activity into the graph */
fun create(
@BindsInstance activity: MediaProjectionAppSelectorActivity,
@BindsInstance view: MediaProjectionAppSelectorView,
@BindsInstance resultHandler: MediaProjectionAppSelectorResultHandler,
): MediaProjectionAppSelectorComponent