Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cache flag values when they are read.

Browse Source 
Bug: 202860494
Test: manual
Change-Id: Icde45251feb344b36bddf5717b9b21c28cb85eb0
This commit is contained in:
Dave Mankoff
2021-10-13 16:00:28 -04:00
parent 38180dfa04
commit c9d778dbfb
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/SystemUI/src-debug/com/android/systemui/flags/FeatureFlagManager.java
View File

@@ -28,6 +28,7 @@ import com.android.systemui.dagger.SysUISingleton;
import org.json.JSONException;
import org.json.JSONObject;
import java.util.HashMap;
import java.util.Map;
import javax.inject.Inject;
@@ -54,6 +55,8 @@ public class FeatureFlagManager implements FlagReader, FlagWriter {
private static final String FLAGS_PERMISSION = "com.android.systemui.permission.FLAGS";
private final SystemPropertiesHelper mSystemPropertiesHelper;
private final Map<Integer, Boolean> mBooleanFlagCache = new HashMap<>();
@Inject
public FeatureFlagManager(SystemPropertiesHelper systemPropertiesHelper, Context context) {
mSystemPropertiesHelper = systemPropertiesHelper;
@@ -64,9 +67,12 @@ public class FeatureFlagManager implements FlagReader, FlagWriter {
/** Return a {@link BooleanFlag}'s value. */
public boolean isEnabled(int id, boolean defaultValue) {
if (!mBooleanFlagCache.containsKey(id)) {
Boolean result = isEnabledInternal(id);
mBooleanFlagCache.put(id, result == null ? defaultValue : result);
}
Boolean result = isEnabledInternal(id);
return result == null ? defaultValue : result;
return mBooleanFlagCache.get(id);
}
/** Returns the stored value or null if not set. */