Merge "Ensure reportFrameMetrics not being called on deleted instance" into sc-dev am: eb24079b9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14775424 Change-Id: I63ff2cbe1d401737e6f2a9cfa69fb4fe9cbc6151
This commit is contained in:
@@ -680,6 +680,7 @@ void CanvasContext::onSurfaceStatsAvailable(void* context, ASurfaceControl* cont
|
||||
frameInfo->set(FrameInfoIndex::FrameCompleted) = std::max(gpuCompleteTime,
|
||||
frameInfo->get(FrameInfoIndex::SwapBuffersCompleted));
|
||||
frameInfo->set(FrameInfoIndex::GpuCompleted) = gpuCompleteTime;
|
||||
std::lock_guard(instance->mFrameMetricsReporterMutex);
|
||||
instance->mJankTracker.finishFrame(*frameInfo, instance->mFrameMetricsReporter);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -170,6 +170,7 @@ public:
|
||||
if (mFrameMetricsReporter.get() != nullptr) {
|
||||
mFrameMetricsReporter->removeObserver(observer);
|
||||
if (!mFrameMetricsReporter->hasObservers()) {
|
||||
std::lock_guard lock(mFrameMetricsReporterMutex);
|
||||
mFrameMetricsReporter.reset(nullptr);
|
||||
}
|
||||
}
|
||||
@@ -295,6 +296,7 @@ private:
|
||||
JankTracker mJankTracker;
|
||||
FrameInfoVisualizer mProfiler;
|
||||
std::unique_ptr<FrameMetricsReporter> mFrameMetricsReporter;
|
||||
std::mutex mFrameMetricsReporterMutex;
|
||||
|
||||
std::set<RenderNode*> mPrefetchedLayers;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user