Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move call to hide IME until next frame

Browse Source 
When dismissing lockscreen after password input, delay call to
IInputMethodManager#hideSoftInput() until the next frame.

This avoids jank during J<LOCKSCREEN_PASSWORD_DISAPPEAR>

Test: atrace before/after
Bug: 230620476
Change-Id: I541eedcbe61350d04056086385f1cf96a1a28bfd
This commit is contained in:
Peter Kalauskas
2022-05-13 17:45:00 +00:00
parent 5d4978d3f5
commit c4e1489b82
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/SystemUI/src/com/android/keyguard/KeyguardPasswordView.java
View File

@@ -32,6 +32,7 @@ import android.animation.ValueAnimator;
import android.content.Context;
import android.graphics.Insets;
import android.graphics.Rect;
import android.os.Trace;
import android.util.AttributeSet;
import android.view.WindowInsetsAnimationControlListener;
import android.view.WindowInsetsAnimationController;
@@ -44,6 +45,7 @@ import androidx.annotation.Nullable;
import com.android.internal.widget.LockscreenCredential;
import com.android.internal.widget.TextViewInputDisabler;
import com.android.systemui.DejankUtils;
import com.android.systemui.R;
import com.android.systemui.animation.Interpolators;
/**
@@ -194,9 +196,17 @@ public class KeyguardPasswordView extends KeyguardAbsKeyInputView {
@Override
public void onAnimationEnd(Animator animation) {
controller.finish(false);
runOnFinishImeAnimationRunnable();
finishRunnable.run();
// Run this in the next frame since it results in a slow binder call
// to InputMethodManager#hideSoftInput()
DejankUtils.postAfterTraversal(() -> {
Trace.beginSection("KeyguardPasswordView#onAnimationEnd");
// // TODO(b/230620476): Make hideSoftInput oneway
// controller.finish() eventually calls hideSoftInput
controller.finish(false);
runOnFinishImeAnimationRunnable();
finishRunnable.run();
Trace.endSection();
});
}
});
anim.setInterpolator(Interpolators.FAST_OUT_LINEAR_IN);