Merge "Do not abort launch logger by invisible drawn activity" into rvc-qpr-dev
This commit is contained in:
committed by
Android (Google) Code Review
commit
c469f76079
@@ -264,7 +264,7 @@ class ActivityMetricsLogger {
|
||||
return;
|
||||
}
|
||||
mLastLaunchedActivity = r;
|
||||
if (!r.noDisplay) {
|
||||
if (!r.noDisplay && !r.mDrawn) {
|
||||
if (DEBUG_METRICS) Slog.i(TAG, "Add pending draw " + r);
|
||||
mPendingDrawActivities.add(r);
|
||||
}
|
||||
@@ -546,7 +546,7 @@ class ActivityMetricsLogger {
|
||||
+ " processSwitch=" + processSwitch + " info=" + info);
|
||||
}
|
||||
|
||||
if (launchedActivity.mDrawn) {
|
||||
if (launchedActivity.mDrawn && launchedActivity.isVisible()) {
|
||||
// Launched activity is already visible. We cannot measure windows drawn delay.
|
||||
abort(info, "launched activity already visible");
|
||||
return;
|
||||
|
||||
@@ -311,6 +311,22 @@ public class ActivityMetricsLaunchObserverTests extends ActivityTestsBase {
|
||||
verifyNoMoreInteractions(mLaunchObserver);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testActivityDrawnBeforeTransition() {
|
||||
mTopActivity.setVisible(false);
|
||||
notifyActivityLaunching(mTopActivity.intent);
|
||||
// Assume the activity is launched the second time consecutively. The drawn event is from
|
||||
// the first time (omitted in test) launch that is earlier than transition.
|
||||
mTopActivity.mDrawn = true;
|
||||
notifyWindowsDrawn(mTopActivity);
|
||||
notifyActivityLaunched(START_SUCCESS, mTopActivity);
|
||||
// If the launching activity was drawn when starting transition, the launch event should
|
||||
// be reported successfully.
|
||||
notifyTransitionStarting(mTopActivity);
|
||||
|
||||
verifyOnActivityLaunchFinished(mTopActivity);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testActivityRecordProtoIsNotTooBig() {
|
||||
// The ActivityRecordProto must not be too big, otherwise converting it at runtime
|
||||
|
||||
Reference in New Issue
Block a user