SurfaceControl: Fix builder

Recently introduced check for isBufferQueueLayer doesn't work
because the FX_SURFACE_NORMAL flag is 0x0 not 0x1 as expected.

Bug: 185941687
Test: Existing tests pass
Change-Id: I1b341bffcd8b0f0c0e7f2e3da27cb201b6e1d6ff
This commit is contained in:
Robert Carr
2021-04-20 16:41:12 -07:00
parent a23475b182
commit c3d4925a04

View File

@@ -1085,8 +1085,8 @@ public final class SurfaceControl implements Parcelable {
throw new IllegalStateException(
"Only buffer layers can set a valid buffer size.");
}
boolean isBqLayer = isBufferQueueLayer();
if (isBqLayer) {
if ((mFlags & FX_SURFACE_MASK) == FX_SURFACE_NORMAL) {
setBLASTLayer();
}
@@ -1310,10 +1310,6 @@ public final class SurfaceControl implements Parcelable {
return (mFlags & FX_SURFACE_EFFECT) == FX_SURFACE_EFFECT;
}
private boolean isBufferQueueLayer() {
return (mFlags & FX_SURFACE_NORMAL) == FX_SURFACE_NORMAL;
}
/**
* @hide
*/