Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix onClientFinished for generate and revoke challenge

Browse Source 
Bug: 186765400
Test: on flame
Test: on sunfish
Test: atest CtsBiometricsTestCases
Change-Id: Ic64f6c5238a7e2e83ebe5f78abd63cfd61e7d27f
This commit is contained in:
Ilya Matyukhin
2021-04-29 15:20:09 -07:00
parent f10473c64c
commit c091528fcc
9 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
services/core/java/com/android/server/biometrics/sensors/RevokeChallengeClient.java
View File

@@ -42,7 +42,6 @@ public abstract class RevokeChallengeClient<T> extends HalClientMonitor<T> {
super.start(callback);
startHalOperation();
mCallback.onClientFinished(this, true /* success */);
}
@Override

1
services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceGenerateChallengeClient.java
View File

@@ -45,6 +45,7 @@ public class FaceGenerateChallengeClient extends GenerateChallengeClient<ISessio
getFreshDaemon().generateChallenge();
} catch (RemoteException e) {
Slog.e(TAG, "Unable to generateChallenge", e);
mCallback.onClientFinished(this, false /* success */);
}
}

1
services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceRevokeChallengeClient.java
View File

@@ -48,6 +48,7 @@ public class FaceRevokeChallengeClient extends RevokeChallengeClient<ISession> {
getFreshDaemon().revokeChallenge(mChallenge);
} catch (RemoteException e) {
Slog.e(TAG, "Unable to revokeChallenge", e);
mCallback.onClientFinished(this, false /* success */);
}
}

1
services/core/java/com/android/server/biometrics/sensors/face/hidl/FaceGenerateChallengeClient.java
View File

@@ -67,6 +67,7 @@ public class FaceGenerateChallengeClient extends GenerateChallengeClient<IBiomet
}
} catch (RemoteException e) {
Slog.e(TAG, "generateChallenge failed", e);
mCallback.onClientFinished(this, false /* success */);
}
}
}

2
services/core/java/com/android/server/biometrics/sensors/face/hidl/FaceRevokeChallengeClient.java
View File

@@ -43,8 +43,10 @@ public class FaceRevokeChallengeClient extends RevokeChallengeClient<IBiometrics
protected void startHalOperation() {
try {
getFreshDaemon().revokeChallenge();
mCallback.onClientFinished(this, true /* success */);
} catch (RemoteException e) {
Slog.e(TAG, "revokeChallenge failed", e);
mCallback.onClientFinished(this, false /* success */);
}
}
}

7
services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintGenerateChallengeClient.java
View File

@@ -47,18 +47,17 @@ class FingerprintGenerateChallengeClient extends GenerateChallengeClient<ISessio
getFreshDaemon().generateChallenge();
} catch (RemoteException e) {
Slog.e(TAG, "Unable to generateChallenge", e);
mCallback.onClientFinished(this, false /* success */);
}
}
void onChallengeGenerated(int sensorId, int userId, long challenge) {
try {
getListener().onChallengeGenerated(sensorId, challenge);
mCallback.onClientFinished(FingerprintGenerateChallengeClient.this,
true /* success */);
mCallback.onClientFinished(this, true /* success */);
} catch (RemoteException e) {
Slog.e(TAG, "Unable to send challenge", e);
mCallback.onClientFinished(FingerprintGenerateChallengeClient.this,
false /* success */);
mCallback.onClientFinished(this, false /* success */);
}
}
}

1
services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintRevokeChallengeClient.java
View File

@@ -48,6 +48,7 @@ class FingerprintRevokeChallengeClient extends RevokeChallengeClient<ISession> {
getFreshDaemon().revokeChallenge(mChallenge);
} catch (RemoteException e) {
Slog.e(TAG, "Unable to revokeChallenge", e);
mCallback.onClientFinished(this, false /* success */);
}
}

1
services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintGenerateChallengeClient.java
View File

@@ -55,6 +55,7 @@ public class FingerprintGenerateChallengeClient
}
} catch (RemoteException e) {
Slog.e(TAG, "preEnroll failed", e);
mCallback.onClientFinished(this, false /* success */);
}
}
}

2
services/core/java/com/android/server/biometrics/sensors/fingerprint/hidl/FingerprintRevokeChallengeClient.java
View File

@@ -45,8 +45,10 @@ public class FingerprintRevokeChallengeClient
protected void startHalOperation() {
try {
getFreshDaemon().postEnroll();
mCallback.onClientFinished(this, true /* success */);
} catch (RemoteException e) {
Slog.e(TAG, "revokeChallenge/postEnroll failed", e);
mCallback.onClientFinished(this, false /* success */);
}
}
}