Merge "Only set excludeLocalRoutes in the bypassable VpnProfile" am: b70a0862ff

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1944537

Change-Id: Ic065fe4ede606af2343bf3a87dc14982ac9b9a9b
This commit is contained in:
Chiachang Wang
2022-01-11 14:06:34 +00:00
committed by Automerger Merge Worker

View File

@@ -35,6 +35,7 @@ import android.annotation.Nullable;
import android.annotation.RequiresFeature;
import android.content.pm.PackageManager;
import android.security.Credentials;
import android.util.Log;
import com.android.internal.annotations.VisibleForTesting;
import com.android.internal.net.VpnProfile;
@@ -70,6 +71,7 @@ import java.util.Objects;
* Exchange, Version 2 (IKEv2)</a>
*/
public final class Ikev2VpnProfile extends PlatformVpnProfile {
private static final String TAG = Ikev2VpnProfile.class.getSimpleName();
/** Prefix for when a Private Key is an alias to look for in KeyStore @hide */
public static final String PREFIX_KEYSTORE_ALIAS = "KEYSTORE_ALIAS:";
/** Prefix for when a Private Key is stored directly in the profile @hide */
@@ -524,7 +526,10 @@ public final class Ikev2VpnProfile extends PlatformVpnProfile {
throw new IllegalArgumentException("Invalid auth method set");
}
builder.setExcludeLocalRoutes(profile.excludeLocalRoutes);
if (profile.excludeLocalRoutes && !profile.isBypassable) {
Log.w(TAG, "ExcludeLocalRoutes should only be set in the bypassable VPN");
}
builder.setExcludeLocalRoutes(profile.excludeLocalRoutes && profile.isBypassable);
return builder.build();
}