Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add logging for badges shown in WifiSettings.

Browse Source 
Bug: 34394557
Test: GmsCore Debug logs (see tron howto).
Change-Id: I14f28278a9478e9ead891e25b1bec54ffa9d90ef
This commit is contained in:
Sundeep Ghuman
2017-01-23 15:41:43 -08:00
parent 6ab568b4ba
commit bf339f5cc5
2 changed files with 67 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
packages/SettingsLib/src/com/android/settingslib/TronUtils.java Normal file
View File

@@ -0,0 +1,63 @@
/*
* Copyright (C) 2015 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settingslib;
import android.content.Context;
import android.net.ScoredNetwork;
import com.android.internal.logging.MetricsLogger;
/** Utilites for Tron Logging. */
public final class TronUtils {
private TronUtils() {};
public static void logWifiSettingsBadge(Context context, int badgeEnum) {
logNetworkBadgeMetric(context, "settings_wifibadging", badgeEnum);
}
/**
* Logs an occurrence of the given network badge to a Histogram.
*
* @param context Context
* @param histogram the Tron histogram name to write to
* @param badgeEnum the {@link ScoredNetwork.Badging} badge value
* @throws IllegalArgumentException if the given badge enum is not supported
*/
private static void logNetworkBadgeMetric(
Context context, String histogram, int badgeEnum)
throws IllegalArgumentException {
int bucket;
switch (badgeEnum) {
case ScoredNetwork.BADGING_NONE:
bucket = 0;
break;
case ScoredNetwork.BADGING_SD:
bucket = 1;
break;
case ScoredNetwork.BADGING_HD:
bucket = 2;
break;
case ScoredNetwork.BADGING_4K:
bucket = 3;
break;
default:
throw new IllegalArgumentException("Unsupported badge enum: " + badgeEnum);
}
MetricsLogger.histogram(context, histogram, bucket);
}
}

5
packages/SettingsLib/src/com/android/settingslib/wifi/AccessPointPreference.java
View File

@@ -34,7 +34,9 @@ import android.util.AttributeSet;
import android.util.SparseArray;
import android.widget.ImageView;
import android.widget.TextView;
import com.android.settingslib.R;
import com.android.settingslib.TronUtils;
import com.android.settingslib.Utils;
public class AccessPointPreference extends Preference {
@@ -184,7 +186,8 @@ public class AccessPointPreference extends Preference {
if (level == -1) {
safeSetDefaultIcon();
} else {
if (mWifiBadge != ScoredNetwork.BADGING_NONE) {
TronUtils.logWifiSettingsBadge(context, mWifiBadge);
if (mWifiBadge != ScoredNetwork.BADGING_NONE) {
// TODO(sghuman): Refactor this to reuse drawable to save memory and add to a
// special subclass of AccessPointPreference
LayerDrawable drawable = Utils.getBadgedWifiIcon(context, level, mWifiBadge);