Merge "Ensure that unparcelling Region only reads the expected number of bytes" into mnc-dev

This commit is contained in:
Derek Sollenberger
2015-05-18 17:37:06 +00:00
committed by Android (Google) Code Review

View File

@@ -206,15 +206,20 @@ static jstring Region_toString(JNIEnv* env, jobject clazz, jlong regionHandle) {
static jlong Region_createFromParcel(JNIEnv* env, jobject clazz, jobject parcel)
{
if (parcel == NULL) {
return NULL;
if (parcel == nullptr) {
return 0;
}
android::Parcel* p = android::parcelForJavaObject(env, parcel);
SkRegion* region = new SkRegion;
size_t size = p->readInt32();
region->readFromMemory(p->readInplace(size), size);
size_t actualSize = region->readFromMemory(p->readInplace(size), size);
if (size != actualSize) {
delete region;
return 0;
}
return reinterpret_cast<jlong>(region);
}