Clicks on the notification group header now collapse

Previously clicks would open the app and have a very
weird transition. We're now collapsing the notification
instead and never allowing expanded groups to be launched

Change-Id: I4ba4e5f695a8b210dd76a38db2783484b90a4f33
Fixes: 110093221
Test: add group, click on header after expanded, observe collapsing
This commit is contained in:
Selim Cinek
2018-12-05 18:45:42 -08:00
parent b53030f983
commit bc34215021
2 changed files with 12 additions and 0 deletions

View File

@@ -182,6 +182,10 @@ public class NotificationEntryManager implements Dumpable, NotificationInflater.
} else if (row.isChildInGroup() && isMenuVisible(row.getNotificationParent())) {
row.getNotificationParent().animateTranslateNotification(0);
return;
} else if (row.isSummaryWithChildren() && row.areChildrenExpanded()) {
// We never want to open the app directly if the user clicks in between
// the notifications.
return;
}
// Mark notification for one frame.

View File

@@ -875,6 +875,7 @@ public class NotificationChildrenContainer extends ViewGroup {
ExpandableNotificationRow child = mChildren.get(childIdx);
child.setChildrenExpanded(childrenExpanded, false);
}
updateHeaderTouchability();
}
public void setContainingNotification(ExpandableNotificationRow parent) {
@@ -1215,6 +1216,13 @@ public class NotificationChildrenContainer extends ViewGroup {
ExpandableNotificationRow child = mChildren.get(i);
child.setUserLocked(userLocked && !showingAsLowPriority());
}
updateHeaderTouchability();
}
private void updateHeaderTouchability() {
if (mNotificationHeader != null) {
mNotificationHeader.setAcceptAllTouches(mChildrenExpanded || mUserLocked);
}
}
public void onNotificationUpdated() {