Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add tracing for setEdgeBackPlugin

Browse Source 
It seems this happens at every unfold, and still takes most of the taskbar initialization time due to `setLayoutParam` when the edge back plugin is set.

This trace will make it more easily visible in traces.

Bug: 219035565
Test: Checked perfetto traces for the new sections to be visible
Change-Id: I74e793467eb37705b2647d0ea9c64bd7b5191d9e
Merged-In: I74e793467eb37705b2647d0ea9c64bd7b5191d9e
This commit is contained in:
Nicolo' Mazzucato
2023-01-16 15:01:07 +00:00
committed by Nicolò Mazzucato
parent 9758d71bd9
commit bbfe111a14
1 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
packages/SystemUI/src/com/android/systemui/navigationbar/gestural/EdgeBackGestureHandler.java
View File

@@ -502,6 +502,15 @@ public class EdgeBackGestureHandler implements PluginListener<NavigationEdgeBack
}
private void updateIsEnabled() {
try {
Trace.beginSection("EdgeBackGestureHandler#updateIsEnabled");
updateIsEnabledTraced();
} finally {
Trace.endSection();
}
}
private void updateIsEnabledTraced() {
boolean isEnabled = mIsAttached && mIsGesturalModeEnabled;
if (isEnabled == mIsEnabled) {
return;
@@ -587,13 +596,18 @@ public class EdgeBackGestureHandler implements PluginListener<NavigationEdgeBack
}
private void setEdgeBackPlugin(NavigationEdgeBackPlugin edgeBackPlugin) {
if (mEdgeBackPlugin != null) {
mEdgeBackPlugin.onDestroy();
try {
Trace.beginSection("setEdgeBackPlugin");
if (mEdgeBackPlugin != null) {
mEdgeBackPlugin.onDestroy();
}
mEdgeBackPlugin = edgeBackPlugin;
mEdgeBackPlugin.setBackCallback(mBackCallback);
mEdgeBackPlugin.setLayoutParams(createLayoutParams());
updateDisplaySize();
} finally {
Trace.endSection();
}
mEdgeBackPlugin = edgeBackPlugin;
mEdgeBackPlugin.setBackCallback(mBackCallback);
mEdgeBackPlugin.setLayoutParams(createLayoutParams());
updateDisplaySize();
}
public boolean isHandlingGestures() {