Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix logspam by JobInfo" into nyc-dev

Browse Source
This commit is contained in:
Dianne Hackborn
2016-04-21 00:39:41 +00:00
committed by Android (Google) Code Review
parent 150553756f b0c83ec062
commit bb9dd3c9fd
1 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
core/java/android/app/job/JobInfo.java
View File

@@ -24,7 +24,7 @@ import android.os.Parcel;
import android.os.Parcelable; import android.os.Parcelable;
import android.os.PersistableBundle; import android.os.PersistableBundle;
import android.util.Log; import android.util.Log;
import static android.util.TimeUtils.formatForLogging; import static android.util.TimeUtils.formatDuration;
import java.util.ArrayList; import java.util.ArrayList;
@@ -760,15 +760,27 @@ public class JobInfo implements Parcelable {
" setRequiresDeviceIdle is an error."); " setRequiresDeviceIdle is an error.");
} }
JobInfo job = new JobInfo(this); JobInfo job = new JobInfo(this);
if (job.intervalMillis != job.getIntervalMillis()) { if (job.isPeriodic()) {
Log.w(TAG, "Specified interval for " + mJobService.getPackageName() + " is " if (job.intervalMillis != job.getIntervalMillis()) {
+ formatForLogging(mIntervalMillis) + ". Clamped to " + StringBuilder builder = new StringBuilder();
formatForLogging(job.getIntervalMillis())); builder.append("Specified interval for ")
} .append(String.valueOf(mJobId))
if (job.flexMillis != job.getFlexMillis()) { .append(" is ");
Log.w(TAG, "Specified interval for " + mJobService.getPackageName() + " is " formatDuration(mIntervalMillis, builder);
+ formatForLogging(mFlexMillis) + ". Clamped to " + builder.append(". Clamped to ");
formatForLogging(job.getFlexMillis())); formatDuration(job.getIntervalMillis(), builder);
Log.w(TAG, builder.toString());
}
if (job.flexMillis != job.getFlexMillis()) {
StringBuilder builder = new StringBuilder();
builder.append("Specified flex for ")
.append(String.valueOf(mJobId))
.append(" is ");
formatDuration(mFlexMillis, builder);
builder.append(". Clamped to ");
formatDuration(job.getFlexMillis(), builder);
Log.w(TAG, builder.toString());
}
} }
return job; return job;
} }