Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix logspam by JobInfo

Browse Source 
Print interval clamp message
only for periodic jobs having
period/flex less than the minimum value.

Bug: 28296128
Change-Id: Id0d7c3b56048582a490bb8214eca491ec2bbdc93
This commit is contained in:
Shreyas Basarge
2016-04-21 00:44:58 +01:00
parent 4db7675d85
commit b0c83ec062
1 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
core/java/android/app/job/JobInfo.java
View File

@@ -24,7 +24,7 @@ import android.os.Parcel;
import android.os.Parcelable;
import android.os.PersistableBundle;
import android.util.Log;
import static android.util.TimeUtils.formatForLogging;
import static android.util.TimeUtils.formatDuration;
import java.util.ArrayList;
@@ -713,15 +713,27 @@ public class JobInfo implements Parcelable {
" setRequiresDeviceIdle is an error.");
}
JobInfo job = new JobInfo(this);
if (job.intervalMillis != job.getIntervalMillis()) {
Log.w(TAG, "Specified interval for " + mJobService.getPackageName() + " is "
+ formatForLogging(mIntervalMillis) + ". Clamped to " +
formatForLogging(job.getIntervalMillis()));
}
if (job.flexMillis != job.getFlexMillis()) {
Log.w(TAG, "Specified interval for " + mJobService.getPackageName() + " is "
+ formatForLogging(mFlexMillis) + ". Clamped to " +
formatForLogging(job.getFlexMillis()));
if (job.isPeriodic()) {
if (job.intervalMillis != job.getIntervalMillis()) {
StringBuilder builder = new StringBuilder();
builder.append("Specified interval for ")
.append(String.valueOf(mJobId))
.append(" is ");
formatDuration(mIntervalMillis, builder);
builder.append(". Clamped to ");
formatDuration(job.getIntervalMillis(), builder);
Log.w(TAG, builder.toString());
}
if (job.flexMillis != job.getFlexMillis()) {
StringBuilder builder = new StringBuilder();
builder.append("Specified flex for ")
.append(String.valueOf(mJobId))
.append(" is ");
formatDuration(mFlexMillis, builder);
builder.append(". Clamped to ");
formatDuration(job.getFlexMillis(), builder);
Log.w(TAG, builder.toString());
}
}
return job;
}