Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use async callback for unfold overlay synchronization

Browse Source 
Replaces synchronous applying of unfold black overlay
transactions with async versions of apply method.
To wait for applying of the second transaction it uses
the new addTransactionCommittedListener API in
SurfaceControl.Transaction.

This also fixes a problem that sometimes the overlay
is not shown when unfolding.

Bug: 227595670
Test: unfold multiple times and check that
 the scrim is visible
Change-Id: Iaa6a8246e592f0bd0d67df755c73be2b3912d157
This commit is contained in:
Nick Chameyev
2022-04-01 16:48:22 +01:00
parent 941937ea1c
commit b7620ab4f2
1 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
packages/SystemUI/src/com/android/systemui/unfold/UnfoldLightRevealOverlayAnimation.kt
View File

@@ -155,21 +155,22 @@ constructor(
newRoot.relayout(params) { transaction ->
val vsyncId = Choreographer.getSfInstance().vsyncId
backgroundExecutor.execute {
// Apply the transaction that contains the first frame of the overlay
// synchronously and apply another empty transaction with
// 'vsyncId + 1' to make sure that it is actually displayed on
// the screen. The second transaction is necessary to remove the screen blocker
// (turn on the brightness) only when the content is actually visible as it
// might be presented only in the next frame.
// See b/197538198
transaction.setFrameTimelineVsync(vsyncId).apply(/* sync */ true)
// Apply the transaction that contains the first frame of the overlay and apply
// another empty transaction with 'vsyncId + 1' to make sure that it is actually
// displayed on the screen. The second transaction is necessary to remove the screen
// blocker (turn on the brightness) only when the content is actually visible as it
// might be presented only in the next frame.
// See b/197538198
transaction
.setFrameTimelineVsync(vsyncId)
.apply()
transaction.setFrameTimelineVsync(vsyncId + 1).apply(/* sync */ true)
Trace.endAsyncSection("UnfoldLightRevealOverlayAnimation#relayout", 0)
callback.run()
}
transaction.setFrameTimelineVsync(vsyncId + 1)
.addTransactionCommittedListener(backgroundExecutor) {
Trace.endAsyncSection("UnfoldLightRevealOverlayAnimation#relayout", 0)
callback.run()
}
.apply()
}
}