Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Address API review comments

Browse Source 
Expand javadocs and change return value to NonNull for
VirtualDeviceManager.createVirtualDevice.
Also removed the redundant @TestApi on the virtual display flag.

Bug: 217742182
Test: Existing tests pass
Change-Id: I381039e6ebe4f5f5046a35e9a3e266ff7f46c369
This commit is contained in:
Maurice Lam
2022-02-10 20:17:51 +00:00
parent 1feb56be88
commit b73e26f971
4 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/api/system-current.txt
View File

@@ -2733,7 +2733,7 @@ package android.companion {
package android.companion.virtual {
public final class VirtualDeviceManager {
method @Nullable @RequiresPermission(android.Manifest.permission.CREATE_VIRTUAL_DEVICE) public android.companion.virtual.VirtualDeviceManager.VirtualDevice createVirtualDevice(int, @NonNull android.companion.virtual.VirtualDeviceParams);
method @NonNull @RequiresPermission(android.Manifest.permission.CREATE_VIRTUAL_DEVICE) public android.companion.virtual.VirtualDeviceManager.VirtualDevice createVirtualDevice(int, @NonNull android.companion.virtual.VirtualDeviceParams);
}
public static interface VirtualDeviceManager.ActivityListener {

1
core/api/test-current.txt
View File

@@ -1187,7 +1187,6 @@ package android.hardware.display {
field public static final int SWITCHING_TYPE_NONE = 0; // 0x0
field public static final int SWITCHING_TYPE_WITHIN_GROUPS = 1; // 0x1
field public static final int VIRTUAL_DISPLAY_FLAG_SHOULD_SHOW_SYSTEM_DECORATIONS = 512; // 0x200
field public static final int VIRTUAL_DISPLAY_FLAG_TRUSTED = 1024; // 0x400
}
}

11
core/java/android/companion/virtual/VirtualDeviceManager.java
View File

@@ -82,14 +82,21 @@ public final class VirtualDeviceManager {
}
/**
* Creates a virtual device.
* Creates a virtual device where applications can launch and receive input events injected by
* the creator.
*
* <p>The {@link android.Manifest.permission#CREATE_VIRTUAL_DEVICE} permission is required to
* create virtual devices, which is only available to system apps holding specific roles.
*
* @param associationId The association ID as returned by {@link AssociationInfo#getId()} from
* Companion Device Manager. Virtual devices must have a corresponding association with CDM in
* order to be created.
* @param params The parameters for creating virtual devices. See {@link VirtualDeviceParams}
* for the available options.
* @return The created virtual device.
*/
@RequiresPermission(android.Manifest.permission.CREATE_VIRTUAL_DEVICE)
@Nullable
@NonNull
public VirtualDevice createVirtualDevice(
int associationId,
@NonNull VirtualDeviceParams params) {

1
core/java/android/hardware/display/DisplayManager.java
View File

@@ -356,7 +356,6 @@ public final class DisplayManager {
* @see #VIRTUAL_DISPLAY_FLAG_SHOULD_SHOW_SYSTEM_DECORATIONS
* @hide
*/
@TestApi
@SystemApi
public static final int VIRTUAL_DISPLAY_FLAG_TRUSTED = 1 << 10;