Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update GraphicsStats proto definition

Browse Source 
Follow ProtoBestPractices and comments suggested by cl/295218381.
Changing proto definition, should be fine, because these are
fields added after the last Android release.
Move PipelineType enum inside GraphicsStats and add a default
UNKNOWN state.
Rename start_millis and end_millis in GraphicsStats atom.
Fields in GraphicsStatsProto cannot be renamed as these were
part of previous Android releases.

Test: Ran "adb shell cmd stats pull-source 10068"
Test: Ran "statsd_testdrive 10068" and it looks OK
Bug: 149646555
Change-Id: Idc326eb2a7eb9ff0be39026e6fec544491b7d8a6
This commit is contained in:
Stan Iliev
2020-02-18 10:12:42 -05:00
parent 6fb74aeefc
commit b65171956c
3 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cmds/statsd/src/atoms.proto
View File

@@ -8203,14 +8203,6 @@ message DangerousPermissionStateSampled {
optional int32 permission_flags = 4;
}
/**
* HWUI renders pipeline type: GL (0) or Vulkan (1).
*/
enum PipelineType {
GL = 0;
VULKAN = 1;
}
/**
* HWUI stats for a given app.
*/
@@ -8224,9 +8216,16 @@ message GraphicsStats {
// The start & end timestamps in UTC as
// milliseconds since January 1, 1970
// Compatible with java.util.Date#setTime()
optional int64 stats_start = 3;
optional int64 start_millis = 3;
optional int64 stats_end = 4;
optional int64 end_millis = 4;
// HWUI renders pipeline type: GL (1) or Vulkan (2).
enum PipelineType {
UNKNOWN = 0;
GL = 1;
VULKAN = 2;
}
// HWUI renders pipeline type: GL or Vulkan.
optional PipelineType pipeline = 5;

5
core/proto/android/service/graphicsstats.proto
View File

@@ -33,8 +33,9 @@ message GraphicsStatsServiceDumpProto {
message GraphicsStatsProto {
enum PipelineType {
GL = 0;
VULKAN = 1;
UNKNOWN = 0;
GL = 1;
VULKAN = 2;
}
option (android.msg_privacy).dest = DEST_AUTOMATIC;

5
libs/hwui/protos/graphicsstats.proto
View File

@@ -30,8 +30,9 @@ message GraphicsStatsServiceDumpProto {
message GraphicsStatsProto {
enum PipelineType {
GL = 0;
VULKAN = 1;
UNKNOWN = 0;
GL = 1;
VULKAN = 2;
}
// The package name of the app