Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Log errors in verifyChallengeInternal()

Browse Source 
It is unexpected for verifyChallengeInternal() to fail, since the
Gatekeeper enrollment of the synthetic password (more specifically, the
Gatekeeper password derived from the synthetic password) should always
be valid.  Therefore, ensure that an error message is logged in all
failure cases.

Bug: 282947979
Change-Id: Ic8d0134bc4f3e0979bf500ffb5a99f2522251d39
This commit is contained in:
Eric Biggers
2023-05-22 17:41:04 +00:00
parent ed2a0e3339
commit b60583c3b1
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java
View File

@@ -1567,8 +1567,10 @@ class SyntheticPasswordManager {
}
return result;
} else if (responseCode == GateKeeperResponse.RESPONSE_RETRY) {
Slog.e(TAG, "Gatekeeper verification of synthetic password failed with RESPONSE_RETRY");
return VerifyCredentialResponse.fromTimeout(response.getTimeout());
} else {
Slog.e(TAG, "Gatekeeper verification of synthetic password failed with RESPONSE_ERROR");
return VerifyCredentialResponse.ERROR;
}
}