Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "WallpaperColors hint computation"

Browse Source 
This reverts commit c50f47d970.

Fixes: 79465234
Reason for revert: Google still does it using private APIs and apps were relying on this behavior, not good for the ecosystem.

Change-Id: I62e2b4cd1e6e562fcdd89c97e599bcdade83381a
This commit is contained in:
Lucas Dupin
2018-05-24 16:33:14 +00:00
parent c50f47d970
commit b5e5053ebc
3 changed files with 2 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/java/android/app/WallpaperColors.java
View File

@@ -137,13 +137,6 @@ public final class WallpaperColors implements Parcelable {
* @param bitmap Source where to extract from.
*/
public static WallpaperColors fromBitmap(@NonNull Bitmap bitmap) {
return fromBitmap(bitmap, false /* computeHints */);
}
/**
* @hide
*/
public static WallpaperColors fromBitmap(@NonNull Bitmap bitmap, boolean computeHints) {
if (bitmap == null) {
throw new IllegalArgumentException("Bitmap can't be null");
}
@@ -193,7 +186,7 @@ public final class WallpaperColors implements Parcelable {
}
}
int hints = computeHints ? calculateDarkHints(bitmap) : 0;
int hints = calculateDarkHints(bitmap);
if (shouldRecycle) {
bitmap.recycle();

2
services/core/java/com/android/server/wallpaper/WallpaperManagerService.java
View File

@@ -458,7 +458,7 @@ public class WallpaperManagerService extends IWallpaperManager.Stub
if (cropFile != null) {
Bitmap bitmap = BitmapFactory.decodeFile(cropFile);
if (bitmap != null) {
colors = WallpaperColors.fromBitmap(bitmap, true /* computeHints */);
colors = WallpaperColors.fromBitmap(bitmap);
bitmap.recycle();
}
}

15
services/tests/servicestests/src/com/android/server/wallpaper/WallpaperServiceTests.java
View File

@@ -20,8 +20,6 @@ import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import android.app.WallpaperColors;
import android.graphics.Color;
import android.graphics.drawable.ColorDrawable;
import android.os.Handler;
import android.os.Message;
import android.os.SystemClock;
@@ -87,17 +85,4 @@ public class WallpaperServiceTests {
assertEquals("OnComputeColors should have been deferred.",
0, eventCountdown.getCount());
}
@Test
public void testFromDrawableTest_doesntComputeHints() {
WallpaperColors wallpaperColors = WallpaperColors.fromDrawable(
new ColorDrawable(Color.BLACK));
assertEquals("WallpaperColors should not support dark theme.", 0,
wallpaperColors.getColorHints() & WallpaperColors.HINT_SUPPORTS_DARK_THEME);
wallpaperColors = WallpaperColors.fromDrawable(
new ColorDrawable(Color.WHITE));
assertEquals("WallpaperColors should not support dark text.", 0,
wallpaperColors.getColorHints() & WallpaperColors.HINT_SUPPORTS_DARK_TEXT);
}
}