Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add package information to RescueParty uiderrors

Browse Source 
Since RescueParty no longer uses a global rescue level, instead
log rescue level successes/failures with package names. These
logs are surfaced in /data/system/uiderrors.txt

Test: adb shell setprop debug.crash_sysui 1; adb shell stop;
      adb shell start; adb shell cat data/system/uiderrors.txt
Bug: 187289291
Change-Id: I088aeea5ac8c5c610b251b53ba79f153ec491c68
This commit is contained in:
Gavin Corkery
2021-05-11 23:34:58 +01:00
parent a1f1ba172b
commit af29e81401
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
services/core/java/com/android/server/RescueParty.java
View File

@@ -361,10 +361,13 @@ public class RescueParty {
try {
executeRescueLevelInternal(context, level, failedPackage);
EventLogTags.writeRescueSuccess(level);
logCriticalInfo(Log.DEBUG,
"Finished rescue level " + levelToString(level));
String successMsg = "Finished rescue level " + levelToString(level);
if (!TextUtils.isEmpty(failedPackage)) {
successMsg += " for package " + failedPackage;
}
logCriticalInfo(Log.DEBUG, successMsg);
} catch (Throwable t) {
logRescueException(level, t);
logRescueException(level, failedPackage, t);
}
}
@@ -427,7 +430,7 @@ public class RescueParty {
pm.reboot(TAG);
}
} catch (Throwable t) {
logRescueException(level, t);
logRescueException(level, failedPackage, t);
}
};
thread = new Thread(runnable);
@@ -441,7 +444,7 @@ public class RescueParty {
try {
RecoverySystem.rebootPromptAndWipeUserData(context, TAG);
} catch (Throwable t) {
logRescueException(level, t);
logRescueException(level, failedPackage, t);
}
}
};
@@ -455,11 +458,15 @@ public class RescueParty {
}
}
private static void logRescueException(int level, Throwable t) {
private static void logRescueException(int level, @Nullable String failedPackageName,
Throwable t) {
final String msg = ExceptionUtils.getCompleteMessage(t);
EventLogTags.writeRescueFailure(level, msg);
logCriticalInfo(Log.ERROR,
"Failed rescue level " + levelToString(level) + ": " + msg);
String failureMsg = "Failed rescue level " + levelToString(level);
if (!TextUtils.isEmpty(failedPackageName)) {
failureMsg += " for package " + failedPackageName;
}
logCriticalInfo(Log.ERROR, failureMsg + ": " + msg);
}
private static int mapRescueLevelToUserImpact(int rescueLevel) {