Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't crash the notification bind if the icon fails to resolve.

Browse Source 
Bug: 189924598
Test: reproduce the bug and notice that instead of an empty collapsed state, you get everything except the icon.
Change-Id: Ibc4bebf0bbf42192ce70b748f98725e312fa54b8
This commit is contained in:
Jeff DeCew
2021-06-18 16:56:30 -04:00
parent e7fc75760a
commit adf5e468d1
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/java/com/android/internal/widget/CachingIconView.java
View File

@@ -257,7 +257,7 @@ public class CachingIconView extends ImageView {
boolean hasColor = color != ColoredIconHelper.COLOR_INVALID;
if (background == null) {
// This is the pre-S style -- colored icon with no background.
if (hasColor) {
if (hasColor && icon != null) {
icon.mutate().setColorFilter(color, PorterDuff.Mode.SRC_ATOP);
}
} else {
@@ -265,7 +265,9 @@ public class CachingIconView extends ImageView {
// colorize the icon itself with the background color, creating an inverted effect.
if (hasColor) {
background.mutate().setColorFilter(color, PorterDuff.Mode.SRC_ATOP);
icon.mutate().setColorFilter(mBackgroundColor, PorterDuff.Mode.SRC_ATOP);
if (icon != null) {
icon.mutate().setColorFilter(mBackgroundColor, PorterDuff.Mode.SRC_ATOP);
}
} else {
background.mutate().setColorFilter(mBackgroundColor, PorterDuff.Mode.SRC_ATOP);
}