Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use JNI region calls in MemoryFile read and write.

Browse Source 
This will reduce copying or pinning, depending on GC policies, which should
improve performance. See dalvik/docs/jni-tips.html#RegionCalls for more information.

Fixes http://b/issue?id=1887911
This commit is contained in:
Bjorn Bringert
2009-06-01 18:33:33 +01:00
parent 641bb3d8df
commit ad984f1933
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/jni/android_os_MemoryFile.cpp
View File

@@ -82,9 +82,7 @@ static jint android_os_MemoryFile_read(JNIEnv* env, jobject clazz,
return -1;
}
jbyte* bytes = env->GetByteArrayElements(buffer, 0);
memcpy(bytes + destOffset, (const char *)address + srcOffset, count);
env->ReleaseByteArrayElements(buffer, bytes, 0);
env->SetByteArrayRegion(buffer, destOffset, count, (const jbyte *)address + srcOffset);
if (unpinned) {
ashmem_unpin_region(fd, 0, 0);
@@ -103,9 +101,7 @@ static jint android_os_MemoryFile_write(JNIEnv* env, jobject clazz,
return -1;
}
jbyte* bytes = env->GetByteArrayElements(buffer, 0);
memcpy((char *)address + destOffset, bytes + srcOffset, count);
env->ReleaseByteArrayElements(buffer, bytes, 0);
env->GetByteArrayRegion(buffer, srcOffset, count, (jbyte *)address + destOffset);
if (unpinned) {
ashmem_unpin_region(fd, 0, 0);