Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix disappearing edges in lists/scrollviews/etc.

Browse Source 
Bug #4093871

This bug was introduced by a change that modified the way fade areas
are cleared. The previous change relied on Rect::intersect() to empty
the intersected rect when the two rects don't intersect. Unfortunately
this is not what intersect() does. The fix is rather simple and
sets the layer's bounds to empty when they don't intersect with the
clip or the viewport. This has the side effect of ignoring the layer
which is the expected result.

Change-Id: Icf0038b9a476c53f8eff7084136aba3033d093e6
This commit is contained in:
Romain Guy
2011-03-15 11:12:25 -07:00
parent 57fccf12e1
commit ad37cd3b5d
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
libs/hwui/OpenGLRenderer.cpp
View File

@@ -407,15 +407,19 @@ bool OpenGLRenderer::createLayer(sp<Snapshot> snapshot, float left, float top,
mSnapshot->transform->mapRect(bounds);
// Layers only make sense if they are in the framebuffer's bounds
bounds.intersect(*snapshot->clipRect);
if (bounds.intersect(*snapshot->clipRect)) {
// We cannot work with sub-pixels in this case
bounds.snapToPixelBoundaries();
// We cannot work with sub-pixels in this case
bounds.snapToPixelBoundaries();
// When the layer is not an FBO, we may use glCopyTexImage so we
// need to make sure the layer does not extend outside the bounds
// of the framebuffer
bounds.intersect(snapshot->previous->viewport);
// When the layer is not an FBO, we may use glCopyTexImage so we
// need to make sure the layer does not extend outside the bounds
// of the framebuffer
if (!bounds.intersect(snapshot->previous->viewport)) {
bounds.setEmpty();
}
} else {
bounds.setEmpty();
}
}
if (bounds.isEmpty() || bounds.getWidth() > mCaches.maxTextureSize ||