Avoid unnecessary smaps logic during app compaction am: 3536bf7b55

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1730081

Change-Id: I589e0fc4fb0377d03b1cccc0d0da55f799f2571f
This commit is contained in:
Edgar Arriaga
2021-06-09 02:51:41 +00:00
committed by Automerger Merge Worker

View File

@@ -135,7 +135,7 @@ static int getAnyPageAdvice(const Vma& vma) {
static int compactProcess(int pid, VmaToAdviseFunc vmaToAdviseFunc) {
ProcMemInfo meminfo(pid);
std::vector<Vma> pageoutVmas, coldVmas;
auto vmaCollectorCb = [&](Vma vma) {
auto vmaCollectorCb = [&coldVmas,&pageoutVmas,&vmaToAdviseFunc](const Vma& vma) {
int advice = vmaToAdviseFunc(vma);
switch (advice) {
case MADV_COLD:
@@ -146,7 +146,7 @@ static int compactProcess(int pid, VmaToAdviseFunc vmaToAdviseFunc) {
break;
}
};
meminfo.ForEachVma(vmaCollectorCb);
meminfo.ForEachVmaFromMaps(vmaCollectorCb);
int err = compactMemory(pageoutVmas, pid, MADV_PAGEOUT);
if (!err) {