BroadcastInterceptingContext: use passed-in broadcast Handler.
Currently, BroadcastInterceptingContext always runs broadcast receivers on the thread that called sendBroadcast. This means: 1. Receivers might run on the wrong thread, making the test less realistic. 2. If any receiver checks what thread it's running on, then either the check needs to be modified or deleted, or the test must call sendBroadcast on the thread that the receiver expects to run on. The latter is impossible when there is more than one receiver that needs to run on more than one thread. This CL adds a setUseRegisteredHandlers method that allows tests to say that they want each receiver to run on the Handler specified at registration time. This CL also enables the new mode for ConnectivityServiceTest, and resolves a TODO to re-enable a disabled thread check. The new mode cannot be enabled by default because it would break most of the tests. [This is a partial cherry-pick of an AOSP change that also made changes to ConnectivityServiceTest, and which conflicts in mainline-prod. This CL only includes the changes to BroadcastInterceptingContext.] Bug: 173331190 Test: atest TetheringTests Merged-In: I3303bb14516f07a55d82a16b59c111ab3f8b0389 Change-Id: I95c2371d4e9f51aab2bc6e6368d133e8a75987cd
This commit is contained in:
@@ -29,7 +29,6 @@ import java.util.ArrayList;
|
||||
import java.util.Iterator;
|
||||
import java.util.List;
|
||||
import java.util.concurrent.ExecutionException;
|
||||
import java.util.concurrent.Future;
|
||||
import java.util.concurrent.FutureTask;
|
||||
import java.util.concurrent.TimeUnit;
|
||||
import java.util.concurrent.TimeoutException;
|
||||
@@ -43,6 +42,8 @@ public class BroadcastInterceptingContext extends ContextWrapper {
|
||||
|
||||
private final List<BroadcastInterceptor> mInterceptors = new ArrayList<>();
|
||||
|
||||
private boolean mUseRegisteredHandlers;
|
||||
|
||||
public abstract class FutureIntent extends FutureTask<Intent> {
|
||||
public FutureIntent() {
|
||||
super(
|
||||
@@ -62,17 +63,24 @@ public class BroadcastInterceptingContext extends ContextWrapper {
|
||||
public class BroadcastInterceptor extends FutureIntent {
|
||||
private final BroadcastReceiver mReceiver;
|
||||
private final IntentFilter mFilter;
|
||||
private final Handler mHandler;
|
||||
|
||||
public BroadcastInterceptor(BroadcastReceiver receiver, IntentFilter filter) {
|
||||
public BroadcastInterceptor(BroadcastReceiver receiver, IntentFilter filter,
|
||||
Handler handler) {
|
||||
mReceiver = receiver;
|
||||
mFilter = filter;
|
||||
mHandler = mUseRegisteredHandlers ? handler : null;
|
||||
}
|
||||
|
||||
public boolean dispatchBroadcast(Intent intent) {
|
||||
if (mFilter.match(getContentResolver(), intent, false, TAG) > 0) {
|
||||
if (mReceiver != null) {
|
||||
final Context context = BroadcastInterceptingContext.this;
|
||||
mReceiver.onReceive(context, intent);
|
||||
if (mHandler == null) {
|
||||
mReceiver.onReceive(context, intent);
|
||||
} else {
|
||||
mHandler.post(() -> mReceiver.onReceive(context, intent));
|
||||
}
|
||||
return false;
|
||||
} else {
|
||||
set(intent);
|
||||
@@ -117,25 +125,38 @@ public class BroadcastInterceptingContext extends ContextWrapper {
|
||||
}
|
||||
|
||||
public FutureIntent nextBroadcastIntent(IntentFilter filter) {
|
||||
final BroadcastInterceptor interceptor = new BroadcastInterceptor(null, filter);
|
||||
final BroadcastInterceptor interceptor = new BroadcastInterceptor(null, filter, null);
|
||||
synchronized (mInterceptors) {
|
||||
mInterceptors.add(interceptor);
|
||||
}
|
||||
return interceptor;
|
||||
}
|
||||
|
||||
/**
|
||||
* Whether to send broadcasts to registered handlers. By default, receivers are called
|
||||
* synchronously by sendBroadcast. If this method is called with {@code true}, the receiver is
|
||||
* instead called by a runnable posted to the Handler specified when the receiver was
|
||||
* registered. This method applies only to future registrations, already-registered receivers
|
||||
* are unaffected.
|
||||
*/
|
||||
public void setUseRegisteredHandlers(boolean use) {
|
||||
synchronized (mInterceptors) {
|
||||
mUseRegisteredHandlers = use;
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public Intent registerReceiver(BroadcastReceiver receiver, IntentFilter filter) {
|
||||
synchronized (mInterceptors) {
|
||||
mInterceptors.add(new BroadcastInterceptor(receiver, filter));
|
||||
}
|
||||
return null;
|
||||
return registerReceiver(receiver, filter, null, null);
|
||||
}
|
||||
|
||||
@Override
|
||||
public Intent registerReceiver(BroadcastReceiver receiver, IntentFilter filter,
|
||||
String broadcastPermission, Handler scheduler) {
|
||||
return registerReceiver(receiver, filter);
|
||||
synchronized (mInterceptors) {
|
||||
mInterceptors.add(new BroadcastInterceptor(receiver, filter, scheduler));
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
Reference in New Issue
Block a user