am 0386d04b: am 581581fe: Merge "Fix all fd leaks in authoring engine" into gingerbread

Merge commit '0386d04b19619b03b6bce830010e11d31d3f8a5c'

* commit '0386d04b19619b03b6bce830010e11d31d3f8a5c':
  Fix all fd leaks in authoring engine
This commit is contained in:
James Dong
2010-08-12 09:32:18 -07:00
committed by Android Git Automerger
2 changed files with 7 additions and 5 deletions

View File

@@ -23,6 +23,7 @@
#include <camera/ICamera.h>
#include <media/IMediaRecorderClient.h>
#include <media/IMediaRecorder.h>
#include <unistd.h>
namespace android {
@@ -373,6 +374,7 @@ status_t BnMediaRecorder::onTransact(
int64_t offset = data.readInt64();
int64_t length = data.readInt64();
reply->writeInt32(setOutputFile(fd, offset, length));
::close(fd);
return NO_ERROR;
} break;
case SET_VIDEO_SIZE: {

View File

@@ -56,11 +56,6 @@ StagefrightRecorder::StagefrightRecorder()
StagefrightRecorder::~StagefrightRecorder() {
LOGV("Destructor");
stop();
if (mOutputFd >= 0) {
::close(mOutputFd);
mOutputFd = -1;
}
}
status_t StagefrightRecorder::init() {
@@ -1158,6 +1153,11 @@ status_t StagefrightRecorder::stop() {
mFlags = 0;
}
if (mOutputFd >= 0) {
::close(mOutputFd);
mOutputFd = -1;
}
return OK;
}