Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent NotificationIconContainer$3 from retaining NotificationEntry

Browse Source 
It has been observed in heap dumps that NotificationIconContainer$3 can
retain a NotificationEntry after the entry has been dismissed. To
prevent this, this change breaks the reference chain between
NotificationIconConatiner$3 and the IconState for the status bar icon.
The cut is performed by setting the animation end action to null after
the animation is started.

Fixes: 160588607
Bug: 161119435
Test: manual - Clear all notifications. Take heap dump. Verify that
weakref in AnimationEndAction has been collected (ie. is null).

Change-Id: I32184a30df89a5172876a43da4896a2e06e3c86c
This commit is contained in:
Robert Snoeberger
2020-07-14 15:00:11 -04:00
parent f57fbbbe14
commit a455113a2b
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationIconContainer.java
View File

@@ -19,8 +19,6 @@ package com.android.systemui.statusbar.phone;
import static com.android.systemui.statusbar.phone.HeadsUpAppearanceController.CONTENT_FADE_DELAY;
import static com.android.systemui.statusbar.phone.HeadsUpAppearanceController.CONTENT_FADE_DURATION;
import android.animation.Animator;
import android.animation.AnimatorListenerAdapter;
import android.content.Context;
import android.content.res.Configuration;
import android.graphics.Canvas;
@@ -807,6 +805,7 @@ public class NotificationIconContainer extends AlphaOptimizedFrameLayout {
} else {
super.applyToView(view);
}
sTempProperties.setAnimationEndAction(null);
boolean inShelf = iconAppearAmount == 1.0f;
icon.setIsInShelf(inShelf);
}