Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Don't trigger links for touches outside of line bounds"

Browse Source
This commit is contained in:
Justin Ghan
2023-04-05 22:25:03 +00:00
committed by Android (Google) Code Review
parent 1e122a0b60 22da5b3a1e
commit a334d184a0
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
core/java/android/text/method/LinkMovementMethod.java
View File

@@ -221,12 +221,20 @@ public class LinkMovementMethod extends ScrollingMovementMethod {
y += widget.getScrollY();
Layout layout = widget.getLayout();
int line = layout.getLineForVertical(y);
int off = layout.getOffsetForHorizontal(line, x);
ClickableSpan[] links;
if (y < 0 || y > layout.getHeight()) {
links = null;
} else {
int line = layout.getLineForVertical(y);
if (x < layout.getLineLeft(line) || x > layout.getLineRight(line)) {
links = null;
} else {
int off = layout.getOffsetForHorizontal(line, x);
links = buffer.getSpans(off, off, ClickableSpan.class);
}
}
ClickableSpan[] links = buffer.getSpans(off, off, ClickableSpan.class);
if (links.length != 0) {
if (links != null && links.length != 0) {
ClickableSpan link = links[0];
if (action == MotionEvent.ACTION_UP) {
if (link instanceof TextLinkSpan) {