Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix NPE with disabled overflow.

Browse Source 
Test: atest SystemUITests
Fixes: 151345204
Change-Id: I470b28c74da39e966568712d15934db6a41615f7
This commit is contained in:
Joshua Tsuji
2020-03-12 17:56:22 -04:00
parent bc7744b995
commit a2433db0ab
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/SystemUI/src/com/android/systemui/bubbles/BubbleStackView.java
View File

@@ -424,6 +424,7 @@ public class BubbleStackView extends FrameLayout {
private int mOrientation = Configuration.ORIENTATION_UNDEFINED;
@Nullable
private BubbleOverflow mBubbleOverflow;
private boolean mShouldShowUserEducation;
@@ -1387,7 +1388,7 @@ public class BubbleStackView extends FrameLayout {
Log.d(TAG, "onBubbleDragStart: bubble=" + bubble);
}
if (bubble.equals(mBubbleOverflow.getIconView())) {
if (mBubbleOverflow != null && bubble.equals(mBubbleOverflow.getIconView())) {
return;
}
@@ -1403,7 +1404,8 @@ public class BubbleStackView extends FrameLayout {
/** Called with the coordinates to which an individual bubble has been dragged. */
public void onBubbleDragged(View bubble, float x, float y) {
if (!mIsExpanded || mIsExpansionAnimating || bubble.equals(mBubbleOverflow.getIconView())) {
if (!mIsExpanded || mIsExpansionAnimating
|| (mBubbleOverflow != null && bubble.equals(mBubbleOverflow.getIconView()))) {
return;
}
@@ -1418,7 +1420,8 @@ public class BubbleStackView extends FrameLayout {
Log.d(TAG, "onBubbleDragFinish: bubble=" + bubble);
}
if (!mIsExpanded || mIsExpansionAnimating || bubble.equals(mBubbleOverflow.getIconView())) {
if (!mIsExpanded || mIsExpansionAnimating
|| (mBubbleOverflow != null && bubble.equals(mBubbleOverflow.getIconView()))) {
return;
}