Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Skip legacy BackgroundDexOptService unit tests when ART Service is in

Browse Source 
use.

Even just instantiating BackgroundDexOptService will result in a
LegacyDexoptDisabledException then.

Test: atest com.android.server.pm.BackgroundDexOptServiceUnitTest
  with dalvik.vm.useartservice=true
Bug: 274098825
Change-Id: I7359ad2887ef2d179f12404de69298b90d9e6636
This commit is contained in:
Martin Stjernholm
2023-03-21 01:43:29 +00:00
parent d2a82123ec
commit a11521db8c
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/core/java/com/android/server/pm/Installer.java
View File

@@ -1177,7 +1177,7 @@ public class Installer extends SystemService {
// TODO(b/260124949): Remove the legacy dexopt code paths, i.e. this exception and all code
// that may throw it.
public LegacyDexoptDisabledException() {
super("Invalid call to legacy dexopt installd method while ART Service is in use.");
super("Invalid call to legacy dexopt method while ART Service is in use.");
}
}

6
services/tests/mockingservicestests/src/com/android/server/pm/BackgroundDexOptServiceUnitTest.java
View File

@@ -47,6 +47,7 @@ import android.content.IntentFilter;
import android.os.HandlerThread;
import android.os.PowerManager;
import android.os.Process;
import android.os.SystemProperties;
import android.util.Log;
import com.android.internal.util.IndentingPrintWriter;
@@ -56,6 +57,7 @@ import com.android.server.pm.dex.DexManager;
import com.android.server.pm.dex.DexoptOptions;
import org.junit.After;
import org.junit.Assume;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -126,6 +128,10 @@ public final class BackgroundDexOptServiceUnitTest {
@Before
public void setUp() throws Exception {
// These tests are only applicable to the legacy BackgroundDexOptService and cannot be run
// when ART Service is enabled.
Assume.assumeFalse(SystemProperties.getBoolean("dalvik.vm.useartservice", false));
when(mInjector.getCallingUid()).thenReturn(Process.FIRST_APPLICATION_UID);
when(mInjector.getContext()).thenReturn(mContext);
when(mInjector.getDexOptHelper()).thenReturn(mDexOptHelper);