Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor Handler with Executor

Browse Source 
Small refactor of changing Handlers to Executors

Bug: 216188165
Test: MidiScope
Test: atest MidiSoloTest
Change-Id: I63e7969fa53affb3bafb8c48f0ba7fac24049e0a
This commit is contained in:
Robert Wu
2022-01-24 23:06:54 +00:00
parent 91cfa7ff07
commit 9f7e717d6c
1 changed files with 5 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
media/java/android/media/midi/MidiManager.java
View File

@@ -112,20 +112,11 @@ public final class MidiManager {
// Binder stub for receiving device notifications from MidiService
private class DeviceListener extends IMidiDeviceListener.Stub {
private final DeviceCallback mCallback;
private final Handler mHandler;
private final Executor mExecutor;
private final int mTransport;
DeviceListener(DeviceCallback callback, Handler handler, int transport) {
mCallback = callback;
mHandler = handler;
mExecutor = null;
mTransport = transport;
}
DeviceListener(DeviceCallback callback, Executor executor, int transport) {
mCallback = callback;
mHandler = null;
mExecutor = executor;
mTransport = transport;
}
@@ -136,13 +127,6 @@ public final class MidiManager {
if (mExecutor != null) {
mExecutor.execute(() ->
mCallback.onDeviceAdded(device));
} else if (mHandler != null) {
final MidiDeviceInfo deviceF = device;
mHandler.post(new Runnable() {
@Override public void run() {
mCallback.onDeviceAdded(deviceF);
}
});
} else {
mCallback.onDeviceAdded(device);
}
@@ -155,13 +139,6 @@ public final class MidiManager {
if (mExecutor != null) {
mExecutor.execute(() ->
mCallback.onDeviceRemoved(device));
} else if (mHandler != null) {
final MidiDeviceInfo deviceF = device;
mHandler.post(new Runnable() {
@Override public void run() {
mCallback.onDeviceRemoved(deviceF);
}
});
} else {
mCallback.onDeviceRemoved(device);
}
@@ -173,13 +150,6 @@ public final class MidiManager {
if (mExecutor != null) {
mExecutor.execute(() ->
mCallback.onDeviceStatusChanged(status));
} else if (mHandler != null) {
final MidiDeviceStatus statusF = status;
mHandler.post(new Runnable() {
@Override public void run() {
mCallback.onDeviceStatusChanged(statusF);
}
});
} else {
mCallback.onDeviceStatusChanged(status);
}
@@ -275,7 +245,11 @@ public final class MidiManager {
*/
@Deprecated
public void registerDeviceCallback(DeviceCallback callback, Handler handler) {
DeviceListener deviceListener = new DeviceListener(callback, handler,
Executor executor = null;
if (handler != null) {
executor = handler::post;
}
DeviceListener deviceListener = new DeviceListener(callback, executor,
TRANSPORT_MIDI_BYTE_STREAM);
try {
mService.registerListener(mToken, deviceListener);