Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't allow activites on virtual displays

Browse Source 
.. unless the caller has ACTIVITY_EMBEDDING permission or is already
present on the display. This prevents non privileged apps from elevating
their FG state by creating a private VD and putting an activity there.
Which would keep their stack considered FG even after their activity on
the main display is no longer visible.

Test: atest CtsWindowManagerDeviceTestCases:MultiDisplaySecurityTests
Bug: 146768652
Change-Id: I1f9662c2bd14b34e00fbc8ebb926538f0329c37a
This commit is contained in:
Linus Tufvesson
2020-02-28 10:21:00 +00:00
parent 26e2c92945
commit 9d8d152aee
4 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
services/core/java/com/android/server/wm/ActivityStackSupervisor.java
View File

@@ -1092,8 +1092,7 @@ public class ActivityStackSupervisor implements RecentTasks.Callbacks {
final boolean uidPresentOnDisplay = displayContent.isUidPresent(callingUid);
final int displayOwnerUid = displayContent.mDisplay.getOwnerUid();
if (displayContent.mDisplay.getType() == TYPE_VIRTUAL && displayOwnerUid != SYSTEM_UID
&& displayOwnerUid != aInfo.applicationInfo.uid) {
if (displayContent.mDisplay.getType() == TYPE_VIRTUAL && displayOwnerUid != SYSTEM_UID) {
// Limit launching on virtual displays, because their contents can be read from Surface
// by apps that created them.
if ((aInfo.flags & ActivityInfo.FLAG_ALLOW_EMBEDDED) == 0) {

1
services/tests/wmtests/Android.bp
View File

@@ -25,6 +25,7 @@ android_test {
"testables",
"ub-uiautomator",
"hamcrest-library",
"compatibility-device-util-axt",
],
libs: [

2
services/tests/wmtests/AndroidManifest.xml
View File

@@ -55,7 +55,7 @@
<activity android:name="com.android.server.wm.TaskStackChangedListenerTest$ActivityInActivityView"
android:resizeableActivity="true" />
<activity android:name="com.android.server.wm.ScreenDecorWindowTests$TestActivity"
android:showWhenLocked="true" />
android:showWhenLocked="true" android:allowEmbedded="true"/>
</application>
<instrumentation

7
services/tests/wmtests/src/com/android/server/wm/ScreenDecorWindowTests.java
View File

@@ -64,6 +64,8 @@ import android.widget.TextView;
import androidx.test.filters.SmallTest;
import com.android.compatibility.common.util.SystemUtil;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
@@ -343,7 +345,10 @@ public class ScreenDecorWindowTests {
intent.addFlags(FLAG_ACTIVITY_NEW_TASK);
final ActivityOptions options = ActivityOptions.makeBasic();
options.setLaunchDisplayId(displayId);
final Activity activity = mInstrumentation.startActivitySync(intent, options.toBundle());
final Activity activity = SystemUtil.runWithShellPermissionIdentity(
() -> mInstrumentation.startActivitySync(intent, options.toBundle()),
"android.permission.ACTIVITY_EMBEDDING");
waitForIdle();
assertEquals(displayId, activity.getDisplayId());