Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

VideoEditor:Issue ID: 3431967

Browse Source 
Fixes memory leak in getProperties
Updated with Review comments

Change-Id: Ie4e8edaee1c76f18d0526b5eae9f9a128e0a3c17
This commit is contained in:
Basavapatna Dattaguru
2011-02-15 21:54:48 -08:00
parent 439f5c6b39
commit 9cfeb6ecfa
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
media/jni/mediaeditor/VideoEditorPropertiesMain.cpp
View File

@@ -122,12 +122,26 @@ jobject videoEditProp_getProperties(
&gotten, pEnv, file, NULL, M4OSA_NULL);
result = M4OSA_fileReadOpen(&context, (M4OSA_Void*)pFile, M4OSA_kFileRead);
if(M4NO_ERROR != result) {
// Free the file path.
videoEditOsal_free(pFile);
pFile = M4OSA_NULL;
}
videoEditJava_checkAndThrowIllegalArgumentException(&gotten, pEnv,
(M4NO_ERROR != result), "file not found");
if(M4NO_ERROR != result)
return(properties);
result = M4OSA_fileReadClose(context);
context = M4OSA_NULL;
// Close the file and free the file context
if (context != NULL) {
result = M4OSA_fileReadClose(context);
context = M4OSA_NULL;
}
// Return if Error
if (M4NO_ERROR != result) {
return (properties); // NULL
}
// Check if the file path is valid.
if (gotten)