Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[hwui] Update dispatchFrameCallbacks to be

Browse Source 
called with timeUntilDeadline/4 instead of
timeUntilDeadline * 0.25f

Previous value of multiply by 0.25f caused the
overflow when timeUntilDeadline was long.

Test: verified with a test app
BUG: 278433880
Change-Id: I54347e0a4f6a1806b3f8c96bfbec7b758dfb6f00
This commit is contained in:
ramindani
2023-05-09 15:01:48 -07:00
parent 94e474cab5
commit 9b64168201
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
libs/hwui/renderthread/RenderThread.cpp
View File

@@ -133,12 +133,23 @@ void RenderThread::frameCallback(int64_t vsyncId, int64_t frameDeadline, int64_t
if (timeLord().vsyncReceived(frameTimeNanos, frameTimeNanos, vsyncId, frameDeadline,
frameInterval) &&
!mFrameCallbackTaskPending) {
ATRACE_NAME("queue mFrameCallbackTask");
mFrameCallbackTaskPending = true;
nsecs_t timeUntilDeadline = frameDeadline - frameTimeNanos;
nsecs_t runAt = (frameTimeNanos + (timeUntilDeadline * 0.25f));
queue().postAt(runAt, [=]() { dispatchFrameCallbacks(); });
using SteadyClock = std::chrono::steady_clock;
using Nanos = std::chrono::nanoseconds;
using toNsecs_t = std::chrono::duration<nsecs_t, std::nano>;
using toFloatMillis = std::chrono::duration<float, std::milli>;
const auto frameTimeTimePoint = SteadyClock::time_point(Nanos(frameTimeNanos));
const auto deadlineTimePoint = SteadyClock::time_point(Nanos(frameDeadline));
const auto timeUntilDeadline = deadlineTimePoint - frameTimeTimePoint;
const auto runAt = (frameTimeTimePoint + (timeUntilDeadline / 4));
ATRACE_FORMAT("queue mFrameCallbackTask to run after %.2fms",
toFloatMillis(runAt - SteadyClock::now()).count());
queue().postAt(toNsecs_t(runAt.time_since_epoch()).count(),
[=]() { dispatchFrameCallbacks(); });
}
}