Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing top notifications cut off on the lockscreen

Browse Source 
The main issue was split_shade_header_height referencing quick_qs_offset_height - I changed that relation for sw720dp-land, I can’t think of any good reason that should be still needed.
Also simplifying getSplitShadeStatusBarHeight - it was assuming that split_shade_header_height would be always referencing quick_qs_offset_height.

Fixes: 216919842
Test: Split shade lockscreen with notificaations - swipe up and see if top notification is clipped weirdly
Change-Id: Iabedab351d88d732f9e4aeebb5ad3bacad35d677
This commit is contained in:
Michal Brzezinski
2022-03-03 18:59:15 +00:00
parent 761938ea59
commit 9a5275e073
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/SystemUI/res/values-sw720dp-land/dimens.xml
View File

@@ -24,4 +24,6 @@
<dimen name="keyguard_split_shade_top_margin">72dp</dimen>
<dimen name="notification_panel_margin_horizontal">24dp</dimen>
<dimen name="split_shade_header_height">56dp</dimen>
</resources>

7
packages/SystemUI/src/com/android/systemui/util/Utils.java
View File

@@ -199,10 +199,13 @@ public class Utils {
/**
* Gets the {@link R.dimen#split_shade_header_height}.
*
* Currently, it's the same as {@link com.android.internal.R.dimen#quick_qs_offset_height}.
* It should be fine to not ignore cutouts as split shade might not want to react to them:
* for split shade header, which is only on bigger screens, either cutout won't be a problem
* (it's usually centered and in split shade that's likely empty area) or we probably want to
* handle it differently.
*/
public static int getSplitShadeStatusBarHeight(Context context) {
return SystemBarUtils.getQuickQsOffsetHeight(context);
return context.getResources().getDimensionPixelSize(R.dimen.split_shade_header_height);
}
/**