Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Show a warning about mismatching test / APK certs

Browse Source 
Bug: 220198493
Test: Treehugger
Test: atest CtsAlarmManagerTestCases # arbitrary CTS to make sure this code path is exercised
Change-Id: I65b34b3344559b45ff5ec791ea32e99dc4191bd1
Merged-in: Iebbe1c8749ef43ac310179698a048a93be47e24b
This commit is contained in:
Makoto Onuki
2022-02-23 11:32:29 -08:00
parent 0e462ae8b1
commit 983caeddb4
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
services/core/java/com/android/server/am/ActivityManagerService.java
View File

@@ -13804,14 +13804,26 @@ public class ActivityManagerService extends IActivityManager.Stub
return false;
}
if (!Build.IS_DEBUGGABLE) {
int match = mContext.getPackageManager().checkSignatures(
ii.targetPackage, ii.packageName);
if (match < 0 && match != PackageManager.SIGNATURE_FIRST_NOT_SIGNED) {
int match = mContext.getPackageManager().checkSignatures(
ii.targetPackage, ii.packageName);
if (match < 0 && match != PackageManager.SIGNATURE_FIRST_NOT_SIGNED) {
if (Build.IS_DEBUGGABLE) {
String message = "Instrumentation test " + ii.packageName
+ " doesn't have a signature matching the target "
+ ii.targetPackage
+ ", which would not be allowed on the production Android builds";
if (callingUid != Process.ROOT_UID) {
Slog.e(TAG, message
+ ". THIS WILL BE DISALLOWED ON FUTURE ANDROID VERSIONS"
+ " unless from a rooted ADB shell.");
} else {
Slog.w(TAG, message);
}
} else {
String msg = "Permission Denial: starting instrumentation "
+ className + " from pid="
+ Binder.getCallingPid()
+ ", uid=" + Binder.getCallingPid()
+ ", uid=" + Binder.getCallingUid()
+ " not allowed because package " + ii.packageName
+ " does not have a signature matching the target "
+ ii.targetPackage;