Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix lint errors in tools/hiddenapi am: f16a93c5b2 am: 5705a1f7ee am: 80167cbe5c

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1580532

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I87be2aa6f4428a699ef45ea1016da85e81c1fbcd
This commit is contained in:
Paul Duffin
2021-02-09 17:19:25 +00:00
committed by Automerger Merge Worker
parent 1b51133ca2 80167cbe5c
commit 9578eebdbb
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/hiddenapi/generate_hiddenapi_lists.py
View File

@@ -153,7 +153,7 @@ def write_lines(filename, lines):
"""Writes list of lines into a file, overwriting the file if it exists.
Args:
filename (string): Path to the file to be writting into.
filename (string): Path to the file to be writing into.
lines (list): List of strings to write into the file.
"""
lines = map(lambda line: line + '\n', lines)

4
tools/hiddenapi/generate_hiddenapi_lists_test.py
View File

@@ -20,7 +20,7 @@ from generate_hiddenapi_lists import *
class TestHiddenapiListGeneration(unittest.TestCase):
def test_filter_apis(self):
# Initialize flags so that A and B are put on the whitelist and
# Initialize flags so that A and B are put on the allow list and
# C, D, E are left unassigned. Try filtering for the unassigned ones.
flags = FlagsDict()
flags.parse_and_merge_csv(['A,' + FLAG_SDK, 'B,' + FLAG_SDK,
@@ -39,7 +39,7 @@ class TestHiddenapiListGeneration(unittest.TestCase):
# Check three things:
# (1) B is selected as valid unassigned
# (2) A is not selected because it is assigned 'whitelist'
# (2) A is not selected because it is assigned to the allow list
# (3) D is not selected because it is not a valid key
self.assertEqual(
flags.get_valid_subset_of_unassigned_apis(set(['A', 'B', 'D'])), set([ 'B' ]))