Merge "Controls a11y - Fix title repetition, min height" into rvc-dev

This commit is contained in:
TreeHugger Robot
2020-04-10 07:14:27 +00:00
committed by Android (Google) Code Review
3 changed files with 3 additions and 2 deletions

View File

@@ -30,6 +30,7 @@
android:layout_gravity="center"
android:layout_width="@dimen/controls_header_app_icon_size"
android:layout_height="@dimen/controls_header_app_icon_size"
android:contentDescription="@null"
android:layout_marginEnd="10dp" />
<TextView

View File

@@ -34,6 +34,7 @@
android:orientation="horizontal"
android:layout_width="0dp"
android:layout_weight="1"
android:minHeight="48dp"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:gravity="center">
@@ -43,6 +44,7 @@
android:layout_gravity="center"
android:layout_width="@dimen/controls_header_app_icon_size"
android:layout_height="@dimen/controls_header_app_icon_size"
android:contentDescription="@null"
android:layout_marginEnd="10dp" />
<TextView

View File

@@ -361,7 +361,6 @@ class ControlsUiControllerImpl @Inject constructor (
.setTint(context.resources.getColor(R.color.control_spinner_dropdown, null))
}
parent.requireViewById<ImageView>(R.id.app_icon).apply {
setContentDescription(selectionItem.getTitle())
setImageDrawable(selectionItem.icon)
}
@@ -586,7 +585,6 @@ private class ItemAdapter(
setText(item.getTitle())
}
view.requireViewById<ImageView>(R.id.app_icon).apply {
setContentDescription(item.appName)
setImageDrawable(item.icon)
}
return view