Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused BubblesManager#maybeCancelSummary()

Browse Source 
Bug: 145659174
Test: atest SystemUITests
Change-Id: Ibeee6718452e2c0fbff3a5dd611c535ff90f59d2
This commit is contained in:
Steve Elliott
2022-08-31 13:36:07 -04:00
parent 2e3425987a
commit 92d75db863
4 changed files with 0 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleController.java
View File

@@ -1336,19 +1336,7 @@ public class BubbleController implements ConfigurationChangeListener {
}
mSysuiProxy.updateNotificationBubbleButton(bubble.getKey());
}
}
mSysuiProxy.getPendingOrActiveEntry(bubble.getKey(), (entry) -> {
mMainExecutor.execute(() -> {
if (entry != null) {
final String groupKey = entry.getStatusBarNotification().getGroupKey();
if (getBubblesInGroup(groupKey).isEmpty()) {
// Time to potentially remove the summary
mSysuiProxy.notifyMaybeCancelSummary(bubble.getKey());
}
}
});
});
}
mDataRepository.removeBubbles(mCurrentUserId, bubblesToBeRemovedFromRepository);

2
libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/Bubbles.java
View File

@@ -276,8 +276,6 @@ public interface Bubbles {
void notifyInvalidateNotifications(String reason);
void notifyMaybeCancelSummary(String key);
void updateNotificationBubbleButton(String key);
void onStackExpandChanged(boolean shouldExpand);

5
packages/SystemUI/src/com/android/systemui/statusbar/notification/collection/coordinator/BubbleCoordinator.java
View File

@@ -144,11 +144,6 @@ public class BubbleCoordinator implements Coordinator {
public void invalidateNotifications(String reason) {
mNotifFilter.invalidateList(reason);
}
@Override
public void maybeCancelSummary(NotificationEntry entry) {
// no-op
}
};
private boolean isInterceptingDismissal(NotificationEntry entry) {

22
packages/SystemUI/src/com/android/systemui/wmshell/BubblesManager.java
View File

@@ -310,18 +310,6 @@ public class BubblesManager {
});
}
@Override
public void notifyMaybeCancelSummary(String key) {
sysuiMainExecutor.execute(() -> {
final NotificationEntry entry = mCommonNotifCollection.getEntry(key);
if (entry != null) {
for (NotifCallback cb : mCallbacks) {
cb.maybeCancelSummary(entry);
}
}
});
}
@Override
public void updateNotificationBubbleButton(String key) {
sysuiMainExecutor.execute(() -> {
@@ -646,15 +634,5 @@ public class BubblesManager {
* filtered from the shade.
*/
void invalidateNotifications(@NonNull String reason);
/**
* Called on a bubbled entry that has been removed when there are no longer
* bubbled entries in its group.
*
* Checks whether its group has any other (non-bubbled) children. If it doesn't,
* removes all remnants of the group's summary from the notification pipeline.
* TODO: (b/145659174) Only old pipeline needs this - delete post-migration.
*/
void maybeCancelSummary(@NonNull NotificationEntry entry);
}
}