Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Do not deep copy bundle in getExtras()" into qt-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2019-04-10 16:00:56 +00:00
committed by Android (Google) Code Review
parent 9aab7ae143 5a8d827526
commit 9214de571f
5 changed files with 16 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/java/android/view/textclassifier/ConversationAction.java
View File

@@ -200,13 +200,11 @@ public final class ConversationAction implements Parcelable {
/**
* Returns the extended data related to this conversation action.
*
* <p><b>NOTE: </b>Each call to this method returns a new bundle copy so clients should
* prefer to hold a reference to the returned bundle rather than frequently calling this
* method.
* <p><b>NOTE: </b>Do not modify this bundle.
*/
@NonNull
public Bundle getExtras() {
return mExtras.deepCopy();
return mExtras;
}
/** Builder class to construct {@link ConversationAction}. */

6
core/java/android/view/textclassifier/ConversationActions.java
View File

@@ -214,13 +214,11 @@ public final class ConversationActions implements Parcelable {
/**
* Returns the extended data related to this conversation action.
*
* <p><b>NOTE: </b>Each call to this method returns a new bundle copy so clients should
* prefer to hold a reference to the returned bundle rather than frequently calling this
* method.
* <p><b>NOTE: </b>Do not modify this bundle.
*/
@NonNull
public Bundle getExtras() {
return mExtras.deepCopy();
return mExtras;
}
/** Builder class to construct a {@link Message} */

12
core/java/android/view/textclassifier/TextClassification.java
View File

@@ -265,13 +265,11 @@ public final class TextClassification implements Parcelable {
/**
* Returns the extended data.
*
* <p><b>NOTE: </b>Each call to this method returns a new bundle copy so clients should
* prefer to hold a reference to the returned bundle rather than frequently calling this
* method.
* <p><b>NOTE: </b>Do not modify this bundle.
*/
@NonNull
public Bundle getExtras() {
return mExtras.deepCopy();
return mExtras;
}
@Override
@@ -635,13 +633,11 @@ public final class TextClassification implements Parcelable {
/**
* Returns the extended data.
*
* <p><b>NOTE: </b>Each call to this method returns a new bundle copy so clients should
* prefer to hold a reference to the returned bundle rather than frequently calling this
* method.
* <p><b>NOTE: </b>Do not modify this bundle.
*/
@NonNull
public Bundle getExtras() {
return mExtras.deepCopy();
return mExtras;
}
/**

12
core/java/android/view/textclassifier/TextLinks.java
View File

@@ -125,13 +125,11 @@ public final class TextLinks implements Parcelable {
/**
* Returns the extended data.
*
* <p><b>NOTE: </b>Each call to this method returns a new bundle copy so clients should
* prefer to hold a reference to the returned bundle rather than frequently calling this
* method.
* <p><b>NOTE: </b>Do not modify this bundle.
*/
@NonNull
public Bundle getExtras() {
return mExtras.deepCopy();
return mExtras;
}
/**
@@ -413,13 +411,11 @@ public final class TextLinks implements Parcelable {
/**
* Returns the extended data.
*
* <p><b>NOTE: </b>Each call to this method returns a new bundle copy so clients should
* prefer to hold a reference to the returned bundle rather than frequently calling this
* method.
* <p><b>NOTE: </b>Do not modify this bundle.
*/
@NonNull
public Bundle getExtras() {
return mExtras.deepCopy();
return mExtras;
}
/**

12
core/java/android/view/textclassifier/TextSelection.java
View File

@@ -112,13 +112,11 @@ public final class TextSelection implements Parcelable {
/**
* Returns the extended data.
*
* <p><b>NOTE: </b>Each call to this method returns a new bundle copy so clients should
* prefer to hold a reference to the returned bundle rather than frequently calling this
* method.
* <p><b>NOTE: </b>Do not modify this bundle.
*/
@NonNull
public Bundle getExtras() {
return mExtras.deepCopy();
return mExtras;
}
@Override
@@ -296,13 +294,11 @@ public final class TextSelection implements Parcelable {
/**
* Returns the extended data.
*
* <p><b>NOTE: </b>Each call to this method returns a new bundle copy so clients should
* prefer to hold a reference to the returned bundle rather than frequently calling this
* method.
* <p><b>NOTE: </b>Do not modify this bundle.
*/
@NonNull
public Bundle getExtras() {
return mExtras.deepCopy();
return mExtras;
}
/**