Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Change contentEquals implementation to operate in O(n) time."

Browse Source
This commit is contained in:
Ján Sebechlebský
2022-12-06 13:10:01 +00:00
committed by Android (Google) Code Review
parent 3f1be47627 740710388b
commit 91824e804f
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/java/android/util/SparseArray.java
View File

@@ -525,9 +525,10 @@ public class SparseArray<E> implements Cloneable {
return false;
}
// size() calls above took care about gc() compaction.
for (int index = 0; index < size; index++) {
int key = keyAt(index);
if (!Objects.equals(valueAt(index), other.get(key))) {
if (mKeys[index] != other.mKeys[index]
|| !Objects.equals(mValues[index], other.mValues[index])) {
return false;
}
}
@@ -545,10 +546,11 @@ public class SparseArray<E> implements Cloneable {
public int contentHashCode() {
int hash = 0;
int size = size();
// size() call above took care about gc() compaction.
for (int index = 0; index < size; index++) {
int key = keyAt(index);
E value = valueAt(index);
hash = 31 * hash + Objects.hashCode(key);
int key = mKeys[index];
E value = (E) mValues[index];
hash = 31 * hash + key;
hash = 31 * hash + Objects.hashCode(value);
}
return hash;