Write new wallpaper files from scratch...

...rather than overwriting the existing wallpaper bitmap file "in
place."  If the new bitmap is smaller than the previous one, we wind
up with the previous image's contents as spurious trailing file
contents.  Also, it means that if any wallpaper image is particularly
large on disk, then we'll forever be backing up that high-water-mark
amount of data every time the wallpaper is changed.

The fix is to open the "write the new bitmap to disk" fd with
MODE_TRUNCATE.

Bug 17285333

Change-Id: I3d8708d72e316834b7ecec20386153a703efddd9
This commit is contained in:
Christopher Tate
2014-09-11 12:37:19 -07:00
parent cde5bb45cc
commit 90f86baebd

View File

@@ -843,7 +843,7 @@ public class WallpaperManagerService extends IWallpaperManager.Stub {
}
File file = new File(dir, WALLPAPER);
ParcelFileDescriptor fd = ParcelFileDescriptor.open(file,
MODE_CREATE|MODE_READ_WRITE);
MODE_CREATE|MODE_READ_WRITE|MODE_TRUNCATE);
if (!SELinux.restorecon(file)) {
return null;
}